Skip to content

Add regression e2e for surfaced OAuth setup failure causes - #1839

Merged
RhysSullivan merged 1 commit into
mainfrom
issue-1330-mcp-oauth
Aug 29, 2026
Merged

Add regression e2e for surfaced OAuth setup failure causes#1839
RhysSullivan merged 1 commit into
mainfrom
issue-1330-mcp-oauth

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

Partially addresses #1330.

OAuth setup failures (oauth.probe / oauth.start against a server with broken discovery metadata) used to reach the sandbox only as Internal tool error [id], with the real cause visible solely in the daemon log. That was fixed by the user-actionable error contract (#1353); this adds the missing end-to-end guard for the exact setup-failure path.

Two cross-target scenarios, both driving the agent-facing tools through the MCP execute sandbox against a broken metadata server:

  • oauth.probe fails with oauth_probe_error and a message naming the malformed metadata.
  • oauth.start scope discovery fails with oauth_start_error carrying the Failed to discover OAuth scopes: … cause chain.

Both assert the opaque Internal tool error mask is not used.

Verification: green on the selfhost and cloud projects. Red-proof: temporarily disabling the user-actionable branch in the tool invoker makes both scenarios fail with Error: Error: Internal tool error [hex] — the original symptom.

No changeset: e2e-only, no published package changes.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 12ac1f4 Commit Preview URL

Branch Preview URL
Aug 29 2026, 06:48 AM

@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 12ac1f4 Aug 29 2026, 06:51 AM

@pkg-pr-new

pkg-pr-new Bot commented Aug 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1839

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1839

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1839

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1839

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1839

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1839

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1839

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1839

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1839

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1839

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1839

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1839

executor

npm i https://pkg.pr.new/executor@1839

commit: 12ac1f4

@RhysSullivan
RhysSullivan marked this pull request as ready for review August 29, 2026 08:16
@RhysSullivan
RhysSullivan merged commit 85bd781 into main Aug 29, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant