Add regression e2e for surfaced OAuth setup failure causes - #1839
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 12ac1f4 | Commit Preview URL Branch Preview URL |
Aug 29 2026, 06:48 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 12ac1f4 | Aug 29 2026, 06:51 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
August 29, 2026 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1330.
OAuth setup failures (
oauth.probe/oauth.startagainst a server with broken discovery metadata) used to reach the sandbox only asInternal tool error [id], with the real cause visible solely in the daemon log. That was fixed by the user-actionable error contract (#1353); this adds the missing end-to-end guard for the exact setup-failure path.Two cross-target scenarios, both driving the agent-facing tools through the MCP
executesandbox against a broken metadata server:oauth.probefails withoauth_probe_errorand a message naming the malformed metadata.oauth.startscope discovery fails withoauth_start_errorcarrying theFailed to discover OAuth scopes: …cause chain.Both assert the opaque
Internal tool errormask is not used.Verification: green on the selfhost and cloud projects. Red-proof: temporarily disabling the user-actionable branch in the tool invoker makes both scenarios fail with
Error: Error: Internal tool error [hex]— the original symptom.No changeset: e2e-only, no published package changes.