Skip to content

Make Microsoft Graph slice URLs first-class spec sources - #1755

Merged
RhysSullivan merged 1 commit into
mainfrom
graph-slice-urls
Aug 26, 2026
Merged

Make Microsoft Graph slice URLs first-class spec sources#1755
RhysSullivan merged 1 commit into
mainfrom
graph-slice-urls

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

Follow-up to #1753, removing the source substitution it introduced. The interception meant the stored specUrl claimed Microsoft's monolith while the bytes came from our release assets — an undisclosed supply-chain hop between the claimed source and what integrations actually ingest.

Now the URL is the byte source, always:

  • Catalog tiles point directly at the slice release URLs; what the add dialog shows, what gets fetched, and what the integration stores as specUrl are the same string.
  • A slice URL's asset name carries its selection (files.yaml → the files preset; default.yaml → the default bundle), and narrowing within a slice travels visibly in the fragment (default.yaml#preset=mail,calendar).
  • Requesting the upstream monolith URL fetches the monolith — never a swapped slice. With a #preset= fragment it still applies the selection filter to the fetched bytes (unchanged, and still memory-fatal in cloud; pasting the monolith URL without a preset match lands in the generic path's size guard with the preset suggestion).
  • The silent slice→monolith fallback is gone with the interception: a slice URL that fails to fetch is an honest error about that URL.

Known follow-up: integrations stored before this change carry the bare monolith specUrl, so their refresh path still fetches the monolith (pre-existing behavior); migrating them to their selection's slice URL is a separate one-off.

Verified: full plugin suite (303 tests) including new URL-classification and no-substitution adapter tests; microsoft-graph-default, microsoft-emulator, and provider-plugins-ui e2e scenarios pass against the live release assets, with the UI scenario asserting the tile now shows the slice URL.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 37ddaa8 Commit Preview URL

Branch Preview URL
Aug 26 2026, 06:35 AM

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 37ddaa8 Aug 26 2026, 06:36 AM

@pkg-pr-new

pkg-pr-new Bot commented Aug 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1755

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1755

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1755

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1755

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1755

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1755

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1755

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1755

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1755

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1755

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1755

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1755

executor

npm i https://pkg.pr.new/executor@1755

commit: 37ddaa8

@RhysSullivan
RhysSullivan marked this pull request as ready for review August 26, 2026 06:40
@RhysSullivan
RhysSullivan merged commit 7c12aee into main Aug 26, 2026
44 checks passed
@RhysSullivan RhysSullivan mentioned this pull request Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant