Adapt 3MF writer to Savitar's const-correct getMeshData API - #21730
Merged
Conversation
getMeshData() now returns a const reference, so mesh data can no longer be written through the getter. Build a MeshData object and assign it via setMeshData() instead.
Contributor
Test Results24 955 tests 24 953 ✅ 51s ⏱️ Results for commit a963967. ♻️ This comment has been updated with latest results. |
HellAholic
marked this pull request as ready for review
July 28, 2026 09:40
Casper Lamboo (casperlamboo)
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMeshData() now returns a const reference, so mesh data can no longer be written through the getter. Build a MeshData object and assign it via setMeshData() instead.
Requires:
Ultimaker/pySavitar#10
CURA-13270