Change to using contextmenu plugin - #10
Open
Alpvax wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
I would recommend squashing and merging (So only the first commit message is listed in the history). |
Trymunx
requested changes
Jan 5, 2019
Trymunx
left a comment
Owner
There was a problem hiding this comment.
I'm happy to merge if:
- you make it possible for me to use my own class name for context menus. It might be nice if this could be scoped so different context menus could be used, although if it's defined only on the root instance of the app this wouldn't be possible anyway (and it wasn't before).
- it's definitely possible for me to overwrite the styles with my own ones. It might be nice to keep the styles set on it as default context menu styles, but these should have colours set, not commented out!
Collaborator
Author
|
What should the default colours be set to? |
Owner
|
I think default colours should be white and grey. Most context menus tend to do this. You could go for blue instead of grey as the highlight colour, as that's common for focus in browsers, but don't think it looks as nice. |
Now displays the DOM element targeted (not the one the listener is attached to) and the VueComponent that declares that element (the lowest parent component).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
U̶n̶a̶b̶l̶e̶ ̶t̶o̶ ̶t̶e̶s̶t̶ ̶o̶n̶ ̶m̶y̶ ̶p̶h̶o̶n̶e̶ ̶b̶e̶f̶o̶r̶e̶ ̶c̶r̶e̶a̶t̶i̶n̶g̶ ̶P̶R̶,̶ ̶s̶o̶ ̶p̶r̶o̶b̶a̶b̶l̶y̶ ̶d̶o̶n̶'̶t̶ ̶m̶e̶r̶g̶e̶ ̶y̶e̶t̶.̶
Ready for merge.