PLA-324: make Ghost-CLI installation reproducible - #479
Draft
9larsons wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm install -g ghost-cliwith a lockfile-backed localnpm ciPATHversions.jsonchangesThis addresses PLA-324.
Security decisions
The install retains
--ignore-scripts. Ghost-CLI itself has no install lifecycle script. The only dependency marked with an install script in this lock is Yarn 1.22.22; itspreinstallonly removes conflicting Corepack shims during a global Yarn install, so it is not needed for this local toolchain. Ghost-CLI,ghost install --help, and its bundled Yarn all work with lifecycle scripts disabled.The Node base-image tags remain unpinned. Docker Official Images resolves them per supported architecture and uses parent-image updates to trigger rebuilds; a single manifest digest would work against that multi-architecture update flow. Build output still records the resolved parent digest.
npm audit --omit=devreports existing issues in Ghost-CLI 1.30.1's dependency tree (1 critical, 4 high, and 4 moderate). This patch freezes that tree and prevents unreviewed transitive changes, but remediation requires upstream Ghost-CLI dependency updates rather than altering the requested CLI version here.Validation
update-ghost-cli-lock.shrefreshes an exact version and is idempotent; stale locks are rejected byapply-templates.shnpm ci --omit=dev --ignore-scriptsand Ghost-CLI 1.30.1 execution pass locallylinux/arm64Bookworm and Alpine image builds pass, including Ghost 6.56.0 installation and native dependency checks/ghost/api/admin/site/using SQLitegit diff --checkpass