Improving library - #1
Open
jnth wants to merge 10 commits into
Open
Conversation
…de the class, add example and update documentation.
…ial number of the device.
Owner
|
I'll be a bit busy, but I'll try to make sure I look at it in the next two weeks. If I don't, feel free to leave another comment pinging me. Thanks! |
Author
|
It's not a problem. Take your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I use your library with Windows and add some new functions and unittest. I add the dll : it's include in a wheel package and made it simple to use in Windows.
It's working in Linux (but the user must compile the library).
I hope you will be interested by this pull request.