fix: #15 by Transparent-fish · Pull Request #16 · Transparent-fish/AtCoder-Helper

Transparent-fish · 2026-07-18T13:04:04Z

No description provided.

github-actions · 2026-07-18T13:04:40Z

PR 审查报告

检查结果

检查项	状态
`pnpm build`	✅
`pnpm lint`	✅
`pnpm test`	✅
函数 <= 130 行	✅

未通过的检查

全部通过，无需修改。

自动生成 by PR Review workflow

deepsource-io · 2026-07-18T13:04:40Z

DeepSource Code Review

We reviewed changes in d0b6b67...fd9c381 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
JavaScript		Jul 18, 2026 1:04p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-07-18T13:04:43Z

+export async function handleFetchSubmitPage(contest: string, send: (payload: Record<string, unknown>) => void) {
+  send({ type: "loading", text: `正在获取 ${contest} 提交页面信息...` });
+  try {
+    const pageData = await fetchSubmitPage(contest);
+    send({ type: "submitPage", submitTasks: pageData.tasks, languages: pageData.languages, csrfToken: pageData.csrfToken });
+    send({ type: "update", text: "已获取提交页面信息" });
+  } catch (error) {
+    if (!handleErrorWithCfAndLogin(error, send)) {
+      send({ type: "error", text: error instanceof Error ? error.message : "获取提交页面失败" });
+    }
+  }
+}


Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

It is considered a best practice to avoid 'polluting' the global scope with variables that are intended to be local to the script. Global variables created from a script can produce name collisions with global variables created from another script, which will usually lead to runtime errors or unexpected behavior. It is mostly useful for browser scripts.

deepsource-io · 2026-07-18T13:04:43Z

+export async function handleSubmitCode(
+  contest: string,
+  taskScreenName: string | undefined,
+  languageId: string | undefined,
+  sourceCode: string | undefined,
+  send: (payload: Record<string, unknown>) => void,
+) {
+  if (!taskScreenName || !languageId || !sourceCode) {
+    send({ type: "submitResult", submitResult: { success: false, message: "提交参数不完整" } });
+    return;
+  }
+  send({ type: "loading", text: "正在提交代码..." });
+  try {
+    const result = await submitCodeWithRedirect(contest, taskScreenName, languageId, sourceCode);
+    send({ type: "submitResult", submitResult: result });
+    if (result.success) send({ type: "update", text: "代码提交成功" });
+    else send({ type: "error", text: result.message });
+  } catch (error) {
+    if (!handleErrorWithCfAndLogin(error, send)) {
+      send({ type: "submitResult", submitResult: { success: false, message: error instanceof Error ? error.message : "提交失败" } });
+    }
+  }
+}


Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

It is considered a best practice to avoid 'polluting' the global scope with variables that are intended to be local to the script. Global variables created from a script can produce name collisions with global variables created from another script, which will usually lead to runtime errors or unexpected behavior. It is mostly useful for browser scripts.

deepsource-io · 2026-07-18T13:04:43Z

+  }
+}
+
+export async function handleSubmitCode(


`handleSubmitCode` has a cyclomatic complexity of 8 with "medium" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

deepsource-io · 2026-07-18T13:04:43Z

+const problemCommands = new Set(["registerContest", "copyMarkdown", "alert"]);
+const submitCommands = new Set(["fetchSubmitPage", "submitCode"]);

 export async function runCommand(


`runCommand` has a cyclomatic complexity of 6 with "medium" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

deepsource-io · 2026-07-18T13:04:43Z

  else if (deeplCommands.has(message.command!)) await runDeepL(message, context, sendToWebview);
-  else if (cookie.has(message.command!)) await runCookie(message, context, sendToWebview);
-  else if (problem.has(message.command!)) await runProblem(message, context, sendToWebview);
+  else if (cookieCommands.has(message.command!)) await runCookie(message, context, sendToWebview);


Forbidden non-null assertion

Using non-null assertions cancels out the benefits of strict null-checking, and introduces the possibility of runtime errors. Avoid non-null assertions unless absolutely necessary. If you still need to use one, write a skipcq comment to explain why it is safe.

deepsource-io · 2026-07-18T13:04:43Z

+async function runSubmit(command: IncomingMessage, context: vscode.ExtensionContext, sendToWebview: (payload: Record<string, unknown>) => void,): Promise<boolean> {
+  switch (command.command) {
+    case "fetchSubmitPage":
+      if (!command.contest) return false;
+      await handleFetchSubmitPage(command.contest, sendToWebview);
+      return true;
+    case "submitCode":
+      if (!command.contest) return false;
+      await handleSubmitCode(command.contest, command.taskScreenName, command.languageId, command.sourceCode, sendToWebview);
+      return true;
+    default:
+      return false;
+  }
+}


Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

It is considered a best practice to avoid 'polluting' the global scope with variables that are intended to be local to the script. Global variables created from a script can produce name collisions with global variables created from another script, which will usually lead to runtime errors or unexpected behavior. It is mostly useful for browser scripts.

deepsource-io · 2026-07-18T13:04:43Z

+export async function fetchSubmitPage(contest: string): Promise<SubmitPage> {
+    const url = `https://atcoder.jp/contests/${contest}/submit`;
+    const html = await fetchText(url);
+
+    const csrfMatch = html.match(/name="csrf_token"[^>]*value="([^"]*)"/i);
+    const csrfToken = csrfMatch ? csrfMatch[1] : "";
+
+    const tasks: Array<{ value: string; label: string }> = [];
+    const taskRegex = /<option[^>]*value="([^"]*)"[^>]*>([^<]*)<\/option>/gi;
+    let taskMatch: RegExpExecArray | null;
+    for (;(taskMatch = taskRegex.exec(html)) !== null;) {
+        const value = taskMatch[1];
+        if (value) tasks.push({ value, label: taskMatch[2].trim() });
+    }
+
+    const languages: LanguageOption[] = [];
+    const langRegex = /<option[^>]*value="(\d+)"[^>]*>([^<]*)<\/option>/gi;
+    let langMatch: RegExpExecArray | null;
+    for (;(langMatch = langRegex.exec(html)) !== null;) {
+        const value = langMatch[1];
+        if (value) languages.push({ id: value, label: langMatch[2].trim() });
+    }
+
+    return { contest, csrfToken, tasks, languages };
+}


Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

It is considered a best practice to avoid 'polluting' the global scope with variables that are intended to be local to the script. Global variables created from a script can produce name collisions with global variables created from another script, which will usually lead to runtime errors or unexpected behavior. It is mostly useful for browser scripts.

deepsource-io · 2026-07-18T13:04:43Z

+    url?: string;
+}
+
+export async function fetchSubmitPage(contest: string): Promise<SubmitPage> {


`fetchSubmitPage` has a cyclomatic complexity of 6 with "medium" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

deepsource-io · 2026-07-18T13:04:43Z

+export async function submitCode(contest: string, taskScreenName: string, languageId: string, sourceCode: string, csrfToken: string): Promise<SubmitStatus> {
+    const url = `https://atcoder.jp/contests/${contest}/submit`;
+    const body =
+        `csrf_token=${encodeURIComponent(csrfToken)}` +
+        `&data.TaskScreenName=${encodeURIComponent(taskScreenName)}` +
+        `&data.LanguageId=${encodeURIComponent(languageId)}` +
+        `&sourceCode=${encodeURIComponent(sourceCode)}`;
+
+    const responseHtml = await fetchTextPost(url, body);
+
+    const errMatch = responseHtml.match(
+        /<div[^>]*class="[^"]*(?:alert-danger|alert-warning|alert-error)[^"]*"[^>]*>([\s\S]*?)<\/div>/i
+    );
+    if (errMatch) {
+        const errMsg = errMatch[1].replace(/<[^>]+>/g, "").trim();
+        return { success: false, message: errMsg };
+    }
+
+    const successed = responseHtml.match(
+        /<div[^>]*class="[^"]*alert-success[^"]*"[^>]*>([\s\S]*?)<\/div>/i
+    );
+    if (successed) {
+        const msg = successed[1].replace(/<[^>]+>/g, "").trim();
+        return { success: true, message: msg, url: `https://atcoder.jp/contests/${contest}/submissions/me` };
+    }
+
+    if (responseHtml.includes("/submissions/me") || responseHtml.includes("Submission")) {
+        return {
+            success: true,
+            message: "代码提交成功",
+            url: `https://atcoder.jp/contests/${contest}/submissions/me`,
+        };
+    }
+
+    return { success: false, message: "提交失败，请检查 Cookie 是否有效" };
+}


Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

It is considered a best practice to avoid 'polluting' the global scope with variables that are intended to be local to the script. Global variables created from a script can produce name collisions with global variables created from another script, which will usually lead to runtime errors or unexpected behavior. It is mostly useful for browser scripts.

deepsource-io · 2026-07-18T13:04:43Z

+export async function submitCodeWithRedirect(contest: string, taskScreenName: string, languageId: string, sourceCode: string): Promise<SubmitStatus> {
+    const pageData = await fetchSubmitPage(contest);
+    if (!pageData.csrfToken) {
+        return { success: false, message: "无法获取 CSRF Token，请检查 Cookie 是否有效" };
+    }
+    return await submitCode(contest, taskScreenName, languageId, sourceCode, pageData.csrfToken);
+}


Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

It is considered a best practice to avoid 'polluting' the global scope with variables that are intended to be local to the script. Global variables created from a script can produce name collisions with global variables created from another script, which will usually lead to runtime errors or unexpected behavior. It is mostly useful for browser scripts.

Transparent-fish · 2026-07-18T13:11:39Z

欸 wc 健忘又犯了，#13 已经在修了

fix: 修复 new 分支与 main 分支的冲突

fd9c381

Transparent-fish changed the title ~~fix: 修复 new 分支与 main 分支的冲突~~ fix: #15 Jul 18, 2026

deepsource-io Bot reviewed Jul 18, 2026

View reviewed changes

Transparent-fish closed this Jul 18, 2026

Conversation

Transparent-fish commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

PR 审查报告

检查结果

未通过的检查

Uh oh!

deepsource-io Bot commented Jul 18, 2026

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

`handleSubmitCode` has a cyclomatic complexity of 8 with "medium" risk

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

`runCommand` has a cyclomatic complexity of 6 with "medium" risk

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

Forbidden non-null assertion

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

`fetchSubmitPage` has a cyclomatic complexity of 6 with "medium" risk

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

Uh oh!

deepsource-io Bot Jul 18, 2026

Choose a reason for hiding this comment

Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

Uh oh!

Transparent-fish commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant