Surface background conversation failure diagnostics - #1464
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed background conversations could return only
failedand a null reply when a runtime wrote its reason to stderr. Completion stored launch errors but dropped other diagnostics, while conversation reads did not inspect the stderr log. Successful recovered runs could also expose an earlier error as their final error.Use one failure-summary policy for task persistence, conversation records, Issue comment completion, and CLI projections. Preserve launch/watchdog causes and terminal structured errors; otherwise fall back to stderr and process exit information. Successful runs never promote warnings or recovered errors into a final error. Read existing failed-task stderr logs with a 16 KiB bound and expose the tail only in detailed output, including a truncation flag. No credential preflight or persisted-schema change.
Validation: targeted regression tests and root typecheck; Alice owner suite (1,662 tests); actual CLI with a real Pi authentication failure, a successful Codex reply, and a historical stderr-only fixture read after restarting an isolated runtime. A prior successful warning-bearing record now reads without a final error.
Full hermetic suite: 776 files passed; 6,891 tests passed, 3 skipped.