Unify Workspace agent defaults in runtime settings - #1463
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace defaults were split between display metadata and runtime preferences, and fresh conversation workers used the interactive fallback rather than the headless default. A Workspace configured with Codex for background work could therefore launch a different runtime.
Move the shipped metadata default into
settings.json.runtime.interactive.defaultAgentthrough migration 0042. Preserve existing fixed defaults, headless settings, model preferences, history, and Session bindings; write the destination before removing the old field. Metadata writes now reject Agent preferences and direct callers to runtime settings. Fresh conversation workers share the headless resolver with Issues. The public default field is a read-only projection of interactive preferences.Validation: root/UI typechecks; migration and route regression specs; isolated real UI preference save; real startup migration; actual
alice conversation askwithout an Agent override selected Codex and returned the expected reply while the interactive default was Claude. Demo workspace settings also rendered successfully.Final full-suite result:
pnpm test— 775 files passed; 6,883 tests passed, 3 skipped.