fix(ci): Release workflow failed on every tag whose release already existed - #73
Merged
Conversation
…xisted `gh release edit` has no `--generate-notes` flag, so the "release already exists" branch could never succeed — it only ever passed when the release was missing and the `create` path ran. Pushing the v5.0.0 tag hit the broken branch and failed. An existing release is now left untouched rather than edited. Beyond fixing the crash, regenerating notes would have overwritten the curated release notes and the uploaded model assets with autogenerated changelog text.
render
Bot
temporarily deployed
to
fix/release-workflow - LesNet PR #73
July 27, 2026 00:16
Destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run 30226581630 failed on the
v5.0.0tag:Root cause
gh release editdoes not support--generate-notes— onlygh release createdoes. So this branch of the workflow could never succeed:It has been latent since the workflow was written and only passed when the release did not already exist, i.e. when the
createpath ran. Pushingv5.0.0— whose release was created beforehand so the model assets could be attached — took the broken branch.Fix
An existing release is now left alone. This is more than crash-avoidance: had
edit --generate-notesworked, it would have overwritten the curated release notes (metrics tables, limitations, usage) with an autogenerated commit changelog.Verified locally: YAML parses, shell logic passes
bash -n, andgh release edit --helpconfirms the flag does not exist.Test plan
python -c "yaml.safe_load(...)"parses the workflowbash -non the extracted scriptgh release edit --helpv*tag push exercises it for real