Skip to content

fix(ci): Release workflow failed on every tag whose release already existed - #73

Merged
Thomasbehan merged 1 commit into
mainfrom
fix/release-workflow
Jul 27, 2026
Merged

fix(ci): Release workflow failed on every tag whose release already existed#73
Thomasbehan merged 1 commit into
mainfrom
fix/release-workflow

Conversation

@Thomasbehan

Copy link
Copy Markdown
Owner

Run 30226581630 failed on the v5.0.0 tag:

unknown flag: --generate-notes
Usage:  gh release edit <tag>

Root cause

gh release edit does not support --generate-notes — only gh release create does. So this branch of the workflow could never succeed:

if gh release view "$TAG" >/dev/null 2>&1; then
  gh release edit "$TAG" --generate-notes   # always exits 1
else
  gh release create "$TAG" --generate-notes --title "LesNet $TAG"
fi

It has been latent since the workflow was written and only passed when the release did not already exist, i.e. when the create path ran. Pushing v5.0.0 — whose release was created beforehand so the model assets could be attached — took the broken branch.

Fix

An existing release is now left alone. This is more than crash-avoidance: had edit --generate-notes worked, it would have overwritten the curated release notes (metrics tables, limitations, usage) with an autogenerated commit changelog.

Verified locally: YAML parses, shell logic passes bash -n, and gh release edit --help confirms the flag does not exist.

Test plan

  • python -c "yaml.safe_load(...)" parses the workflow
  • bash -n on the extracted script
  • Confirmed against gh release edit --help
  • Next v* tag push exercises it for real

…xisted

`gh release edit` has no `--generate-notes` flag, so the "release already
exists" branch could never succeed — it only ever passed when the release
was missing and the `create` path ran. Pushing the v5.0.0 tag hit the broken
branch and failed.

An existing release is now left untouched rather than edited. Beyond fixing
the crash, regenerating notes would have overwritten the curated release
notes and the uploaded model assets with autogenerated changelog text.
@render
render Bot temporarily deployed to fix/release-workflow - LesNet PR #73 July 27, 2026 00:16 Destroyed
@Thomasbehan
Thomasbehan merged commit 2de5a1c into main Jul 27, 2026
6 checks passed
@Thomasbehan
Thomasbehan deleted the fix/release-workflow branch July 27, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant