Improve notifications - #77
Merged
Merged
Conversation
rustybee42
force-pushed
the
rb/dont-wait-for-notifications
branch
from
August 13, 2026 10:38
89ffbcd to
cd4f610
Compare
philippfalk
requested changes
Aug 13, 2026
philippfalk
left a comment
philippfalk
left a comment
Member
There was a problem hiding this comment.
Looks good for the most part. I had some trouble understanding the new tracker mechanism which was partly caused by a misleading comment.
* Don't wait for sending out notifications in update_node() and map_target() as server nodes only have a one second timeout before they consider registration failed. In some systems, apparently dumping the udp messages takes longer than that. * Improve send_notifications() to only do one db query, not multiple, and call broadcast_datagram() only once. * Improve notification trace logging
rustybee42
force-pushed
the
rb/dont-wait-for-notifications
branch
from
August 14, 2026 07:04
548d095 to
966b08e
Compare
philippfalk
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits.
Fixes https://github.com/ThinkParQ/beegfs-core/issues/4772