Refactor/enchantment helpers - #29
Draft
RandyChihuahua wants to merge 7 commits into
Draft
Conversation
These are local Claude Code context docs, not meant to ship in the PR. Removes them from git tracking (files remain on disk) and ignores CLAUDE.md/INDEX.md going forward. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0143sWrFVXpuj8SMbSSGNgft
SlyDevil
reviewed
Aug 31, 2026
|
|
||
| private static int CalculateCustomResourceCost(int skillValue) | ||
| { | ||
| var factor = Hero.MainHero.GetCultureSpecificCustomResource().GetCustomResourceGeneralizedFactor(); |
Contributor
There was a problem hiding this comment.
I'm unsure to what degree that factor has been reflected upon, balanced around, or tested. This will need specific testing to see how it plays out in practice.
SlyDevil
reviewed
Aug 31, 2026
| | `BattleMechanics/AI/` (all of it: `CastingAI/`, `TeamAI/`, `ArtilleryAI/`, `CivilianMissionAI/`, `CommonAIFunctions/`) | FW | Battle-simulation infrastructure, not a toggleable feature — every battle uses it regardless of which content modules are involved. | | ||
| | `BattleMechanics/` root (`TORBattleAgentLogic`, `AddAgentComponentsMissionLogic`, `CustomCrosshairMissionBehavior`, `CinematicCameraMissionView`) | FW | Generic mission plumbing. | | ||
| | `BattleMechanics/` root — `CareerPerkMissionBehavior` | MOD → `Careers/` | Career-specific despite living at `BattleMechanics/` root today. | | ||
| | `BattleMechanics/` root — `TORMonsterSiegeLogic`, `SiegeEarlyVictoryMissionLogic` | MOD → `TORCustomSettlement/` | Monster-siege support exists for Troll Cave content. | |
Contributor
There was a problem hiding this comment.
Siege support is for things like troll and treemen being able to bash down gates and not try to climb stairs as they'll get stuck due to size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly splitting into 2 files, and refactoring one completely. I tested and it works.
Also added a condition when the player has neither enough gold or special currency.