Fix S18.6 self-test to account for the design freeze downgrading EnforcementUnevidenced - #40
Merged
Merged
Conversation
…rcementUnevidenced design/FROZEN.md exists on this tree, so per design/20-contract.md "The freeze", a blocking EnforcementUnevidenced finding is downgraded to reported and the run exits 0 rather than 1 (I21). The S18.6 self-test predated the freeze marker and still asserted the pre-freeze exit code and Findings-list location. Fixes #38.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/Test-DesignState.Tests.ps1's S18.6 test expected the pre-freeze exit code (1) and the finding in.Findingswhen strippingSupersededBy:from a real superseded decision record.design/FROZEN.mdexists on this tree, anddesign/20-contract.md§ The freeze specifies that while it exists, every blocking class — includingEnforcementUnevidenced— is downgraded to reported rather than blocking; exit stays 0 (I21)..Reportedfor the finding while frozen, and to check both.Findingsand.Reportedare clear once the record is restored.Closes #38.
Test plan
Expected 1, but got 0.— same failure CI is showing on maintools/Test-DesignState.Tests.ps1suite: 123 passed, 0 failed