fix(helm): track the app release line in the chart version - #615
Merged
Conversation
The chart sat at 0.1.1 while the app shipped 1.0.0, and appVersion was unset, so every rendered object carried an empty app.kubernetes.io/version label. The omission was deliberate once: appVersion made no sense while the application image was bring-your-own, because the SaaS image bakes its domain at build time. The self-host image removed that constraint — it is domain-agnostic and multi-arch, and the chart defaults to it — so the chart can name the release it ships against. Set version and appVersion to 1.0.0. image.tag stays "latest" by default; pinning it to a release is documented in values.yaml and unchanged here.
5 tasks
Contributor
Author
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
therealbrad
added a commit
that referenced
this pull request
Sep 8, 2026
The chart sat at 0.1.1 while the app shipped 1.0.0, and appVersion was unset, so every rendered object carried an empty app.kubernetes.io/version label. The omission was deliberate once: appVersion made no sense while the application image was bring-your-own, because the SaaS image bakes its domain at build time. The self-host image removed that constraint — it is domain-agnostic and multi-arch, and the chart defaults to it — so the chart can name the release it ships against. Set version and appVersion to 1.0.0. image.tag stays "latest" by default; pinning it to a release is documented in values.yaml and unchanged here. (cherry picked from commit 5d34f08)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Helm chart sat at
0.1.1while the app shipped1.0.0, andappVersionwas unset — so every rendered object carried an emptyapp.kubernetes.io/versionlabel.Sets both
versionandappVersionto1.0.0.The
appVersionomission was deliberate once. Its stated rationale was that the application image is bring-your-own because the image bakes its domain at build time — true of the SaaS image, but not oftestplanit-selfhost, which is domain-agnostic and multi-arch and is what the chart now defaults to. That constraint is gone, so the chart can name the release it ships against.image.tagstayslatestby default. Pinning it to a release is already documented invalues.yamland is unchanged here.Type of Change
How Has This Been Tested?
helm lintpasses, andhelm templatenow rendersapp.kubernetes.io/version: "1.0.0"on every object where it was previously empty. Image references resolve toghcr.io/testplanit/testplanit-selfhost:latestand:latest-workers, matching whatrelease-selfhost.ymlpublishes.Checklist
Additional Notes
This does not by itself make the chart installable.
ghcr.io/testplanit/testplanit-selfhosthas never been published, so ahelm installfrom the current chart still fails to pull. That needs the package to be seeded once with awrite:packagescredential —GITHUB_TOKENcannot create a package that does not yet exist, which is whyrelease-selfhost.ymlfailed withdenied: permission_denied: write_package.Chart publishing is also still manual (
helm push); no workflow does it. That is why the chart version drifted from the app in the first place, and is worth automating inrelease-selfhost.ymlas a follow-up.