feat(vehicle): add format_usb and delete_dashcam_clips signed commands (destructive - please review)#95
Merged
Merged
Conversation
Wraps the two remaining destructive VehicleAction fields with no confirmation guard, matching the existing erase_user_data() precedent: this library exposes the signed command as-is and leaves any confirmation UX to the caller.
Bre77
force-pushed
the
fm/tfa-cmd-destructive
branch
from
July 22, 2026 22:23
ff27691 to
144d1b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
format_usb()anddelete_dashcam_clips()toCommands, wrapping the two remaining destructiveVehicleActionproto fields (FormatUSBAction,DeleteDashcamClipsAction) for full-coverage parity with the rest of the signed-command surface.format_usb()erases all files on the vehicle's connected USB drive;delete_dashcam_clips()erases all stored dashcam clips. Both are irreversible.erase_user_data()precedent already in this codebase (commands.py), which is an equally destructive no-arg command with no guardrail. This library exposes the signed command as-is and leaves any confirmation UX to the caller, consistent with every other command here.tests/test_ble_destructive_commands.pyconfirm each command builds the correct signed message (format_usb=True/delete_clips=True) over the mocked BLE transport - no live/destructive testing performed, matching howerase_user_data()itself was tested.