fix(tests): align subagent catalog division count with bundled library - #426
Merged
Conversation
The bundled subagent catalog now loads 19 divisions (272 agents), but two tests still hard-coded an expected count of 16. Update the assertions so the pre-commit suite is green.
monkeypatch.setattr(..., raising=True) fails when getuid is missing on Windows; use raising=False so the USERNAME fallback path is covered. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two pre-existing test failures that keep
developred. The bundled subagent catalog now loads 19 divisions (272 agents), but two tests still hard-coded the old count of 16:tests/unit/agents/test_subagent_catalog.py::test_bundled_library_non_emptytests/integration/test_subagents_api.py::test_catalog_divisionsUpdate both assertions from
== 16to== 19to match the current catalog.Notes
developgo green independently of those feature branches — once this merges, the fix commit drops out of their diffs automatically.Test plan
uv run pytest tests/unit/agents/test_subagent_catalog.py::test_bundled_library_non_empty tests/integration/test_subagents_api.py::test_catalog_divisions -q