Fix Tab5 Display Issues

[Shadowtrance]

And add PPA rotation to lvgl_display

Summary by CodeRabbit

• Performance

  • Improved display rendering performance on supported devices through hardware-accelerated graphics processing.
  • Enabled smoother software-based screen rotation, with automatic fallback for unsupported formats or hardware.

• Reliability

  • Improved display update synchronization to prevent visual artifacts and ensure completed transfers before subsequent updates.

• Compatibility

  • Updated display configurations to support enhanced buffering and acceleration on both device revisions.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7c2d732f-10e6-440d-a1cd-76705ad9a5c5

📥 Commits

Reviewing files that changed from the base of the PR and between 8b92aa8 and d562856.

📒 Files selected for processing (9)

• Devices/m5stack-tab5/Source/devices/devices_v1.cpp
• Devices/m5stack-tab5/Source/devices/devices_v2.cpp
• Devices/m5stack-tab5/device.properties
• Drivers/ili9881c-module/source/ili9881c.cpp
• Drivers/st7123-module/source/st7123.cpp
• Modules/lvgl-module/CMakeLists.txt
• Modules/lvgl-module/include/tactility/lvgl_ppa.h
• Modules/lvgl-module/source/lvgl_display.c
• Modules/lvgl-module/source/lvgl_ppa.c

---

📝 Walkthrough

Walkthrough

Adds a PPA backend for supported ESP32-P4 targets, including aligned DMA-capable output buffers, rotation operations, cleanup, and unsupported-target stubs. LVGL display flushing now attempts PPA rotation for tiles and full frames before falling back to software rotation. Tab5 display configurations enable two frame buffers and DMA2D. The ILI9881C and ST7123 drivers track asynchronous bitmap-transfer completion with semaphores and callbacks. The LVGL module also adds the ESP32-P4 PPA build dependency and updates draw-buffer alignment configuration.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 18.75% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is related to the Tab5 display work, but it is too vague to convey the specific changes made.	Rename it to mention the main change, such as enabling PPA rotation and fixing Tab5 display buffering/transfer handling.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[KenVanHoeylandt]

Thank you!