fix(harbor): align task schema, safe staging, and judge status - #353
Open
reacher-z wants to merge 1 commit into
Open
fix(harbor): align task schema, safe staging, and judge status#353reacher-z wants to merge 1 commit into
reacher-z wants to merge 1 commit into
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens the existing Harbor integration without changing the native runner contract.
1.4, centralized inHARBOR_SCHEMA_VERSION, matching Harbor0.22.xtask templates.extra_infonormalization/path validation and fail fast on path escapes, missing files, non-files, and basename collisions instead of silently skipping or overwriting staged files.judge_status = "inconclusive",failure_category = "judge_inconclusive", and numericjudge_inconclusive = 1inreward.json.CHANGELOG.md.Related to #331. The real Docker smoke gate remains tracked in #350; security and policy follow-ups are #349, #351, and #352.
Verification
uv run --frozen pytest -q->288 passed, 3 skippeduv run --with harbor==0.22.0 pytest tests/test_harbor_version_compatibility.py -q->2 passeduv run --frozen ruff check .uv run --frozen ruff format --check .uv run --frozen pyrightuv buildplustwine check-> wheel and sdist passedDocker is not installed in the local environment, so this PR does not claim to provide a Harbor container E2E result; #350 is the requested CI gate for that coverage.
@Perry2004 please review the Harbor schema/version contract and the result semantics, especially whether
judge_inconclusiveshould be promoted into Harbor's aggregate status in the follow-up CI work.