Drop the hickory DNS feature - #8
Merged
Merged
Conversation
JuliDi
force-pushed
the
julian/drop-hickory
branch
from
August 7, 2026 07:41
dc8f3a2 to
d0f3fb2
Compare
hyper-hickory replaced the default resolver with an async one, which this crate does not benefit from: it posts to a single hostname over a pooled connection, so DNS lookups are rare. It doubled the dependency tree, from 74 to 150 crates, and pulled in RUSTSEC-2026-0119 via hickory-proto 0.25, for which no fixed release is reachable through hyper-hickory 0.8. Also fix a stale cargo-make reference in Cargo.toml.
JuliDi
force-pushed
the
julian/drop-hickory
branch
from
August 7, 2026 08:03
d0f3fb2 to
c082d61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since hyper-hickory seems abandoned and depends on vulnerable versions of hickory, I decided to drop the hickory feature entirely.
We only make one DNS request to cloudflare.com and from then on it is cached anyway. So there is no big benefit of having hickory.
Plus: we get rid of a lot of transitive dependencies.