fix(gui): stop affineAlign when fewer than three traces selected#107
Open
dustenhubbard wants to merge 1 commit into
Open
fix(gui): stop affineAlign when fewer than three traces selected#107dustenhubbard wants to merge 1 commit into
dustenhubbard wants to merge 1 commit into
Conversation
The too-few-traces guard showed the "select 3 or more traces" notification but did not return, so execution fell through into the alignment code with an invalid selection. With equal counts under three this silently applied a bogus (or NaN) transform to the section and saved it; with nothing selected it raised an unhandled IndexError. Return after the notification so the guard stops execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
affineAlignshowed the "select 3 or more traces" notification but did not return, so it fell through into the alignment code with an invalid selection. With equal counts under three this silently applied a bogus or NaN transform to the section and saved it, and with nothing selected it raised an unhandledIndexError. This adds the missingreturnafter the notification so the guard stops execution.Closes #106.