Skip to content

Fix canonical type cartouche names - #392

Merged
witbrock merged 1 commit into
mainfrom
agent/fix-type-cartouche-names
Aug 18, 2026
Merged

Fix canonical type cartouche names#392
witbrock merged 1 commit into
mainfrom
agent/fix-type-cartouche-names

Conversation

@witbrock

Copy link
Copy Markdown
Member

What changed

  • Resolve subtype, instance, and direct-type labels from canonical relation-backed hasName values in one batch.
  • Preserve authored acronyms and Unicode exactly, with automatic bidirectional text direction in the UI.
  • Remove GET-time persistence of identifier-derived display guesses.
  • Remove the ASCII CamelCase rewrite from inline name editing.

Root cause

The affected list projections ignored canonical hasName relations and reconstructed labels from lossy identifiers with title-casing. That turned identifiers such as current_uo_asail_ph_d_student into Current Uo Asail Ph D Student. The name editor could independently split UoA and PhD when merely opened and blurred.

User impact

Type cartouches now show the stored canonical names, including acronyms and multilingual Unicode text, without inventing spaces or changing code points. Ordinary subtype and instance reads no longer mutate ontology names.

Validation

  • 17 focused backend tests passed; one unrelated known metadata assertion was excluded.
  • 18 focused frontend tests passed.
  • Ruff, Python compilation, JavaScript syntax, and git diff --check passed.
  • Frontend static lint completed with 0 errors and 13 pre-existing warnings.
  • Isolated AgentTest API and Playwright replay showed Current UoA SAIL PhD Student, Current UoA PhD Student, and UoA CS PhD Student, with word-spacing: 0px and dir=auto.

monkeypatch.setattr(
concept_service.ConceptsRepository,
"collection",
staticmethod(lambda: object()),
@witbrock
witbrock merged commit da0285c into main Aug 18, 2026
4 checks passed
@witbrock
witbrock deleted the agent/fix-type-cartouche-names branch August 18, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant