Fix canonical type cartouche names - #392
Merged
Merged
Conversation
| monkeypatch.setattr( | ||
| concept_service.ConceptsRepository, | ||
| "collection", | ||
| staticmethod(lambda: object()), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
hasNamevalues in one batch.Root cause
The affected list projections ignored canonical
hasNamerelations and reconstructed labels from lossy identifiers with title-casing. That turned identifiers such ascurrent_uo_asail_ph_d_studentintoCurrent Uo Asail Ph D Student. The name editor could independently splitUoAandPhDwhen merely opened and blurred.User impact
Type cartouches now show the stored canonical names, including acronyms and multilingual Unicode text, without inventing spaces or changing code points. Ordinary subtype and instance reads no longer mutate ontology names.
Validation
git diff --checkpassed.Current UoA SAIL PhD Student,Current UoA PhD Student, andUoA CS PhD Student, withword-spacing: 0pxanddir=auto.