Make paper recovery and failure outcomes truthful - #387
Merged
Conversation
JVNAUTOSCI-2639
JVNAUTOSCI-2640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Makes paper representation recover honestly from local arXiv acquisition failures, prevents a zero-success batch from being reported as completed, and keeps aggregate workflow failures specific.
Root cause
Process-wide async proxy initialisation locks were reused across the fresh event loops created by the synchronous catalogue bridge. The represented paper workflow also treated provider identity as recovery policy and accepted a bookkeeping-level partial result even when no item succeeded. Failure-like terminal states then lost their authored aggregate reason.
Scope
Validation
git diff --checkJira: JVNAUTOSCI-2638, JVNAUTOSCI-2639, JVNAUTOSCI-2640