Skip to content

feat(chat): configurable interactive answer timeout - #362

Draft
FlowerRealm wants to merge 1 commit into
Stack-Cairn:mainfrom
FlowerRealm:feat/configurable-ask-timeout
Draft

feat(chat): configurable interactive answer timeout#362
FlowerRealm wants to merge 1 commit into
Stack-Cairn:mainfrom
FlowerRealm:feat/configurable-ask-timeout

Conversation

@FlowerRealm

Copy link
Copy Markdown
Contributor

What

Allow configuring the answer window shared by the AskUserQuestion card and the tool approval barsettings.system.interactiveTimeoutMinutes (minutes, default 3, preserving current behavior). A very large value (e.g. 99999) ≈ never time out.

Addresses the timeout-configuration part of #354. Notifications / taskbar flashing are out of scope (tracked separately).

How

  • New interactiveTimeoutMinutes field in SystemSettings, synced to the gateway WebUI; input added to the mirrored System Tools settings section.
  • Desktop injects the window (minutes → ms) into both tools at runtime via module-level config (setAskUserQuestionTimeoutMs / setToolApprovalTimeoutMs) — avoids threading through the 6+ tool-preview call sites.
  • Because "never" is just a large number, every deadline stays a finite timestamp: the tools always set a timer and the countdown logic is unchanged — ToolApprovalBar.tsx and gatewayToolPreview.ts end up with zero diff.
  • The tool description sent to the model is generated from the actual configured window.

Verification

  • agent-gui frontend: 1418 pass
  • agent-gateway web: 493 pass
  • both tsc --noEmit clean
  • mirror consistency (scripts/check-mirror.mjs): 119 files byte-identical

Make the answer window shared by the AskUserQuestion card and the tool
approval bar configurable via settings.system.interactiveTimeoutMinutes
(minutes, default 3, preserving current behavior). A very large value
(e.g. 99999) approximates never timing out. The window is injected into
both tools at runtime; every deadline stays a finite timestamp, so the
countdown logic needs no special never-handling.

Refs Stack-Cairn#354 (timeout configurability).
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

PR governance checks failed — this PR has been converted to draft.

  • No linked issue: the PR body must contain Closes #123 / Fixes #123 / Resolves #123. This project requires an issue before a PR — see the contribution guidelines.
  • UI change without screenshots: this PR modifies frontend code. Please add before/after screenshots or a recording under "Screenshots / preview" in the PR body.

Fix the items above, then click Ready for review to re-run the checks.

@StackCairn
StackCairn marked this pull request as draft August 2, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant