Skip to content

chore: upgrade Taquito to v25 and drop Beacon overrides - #457

Merged
KevinMehrabi merged 6 commits into
StableTechnologies:mainfrom
AK-APRIORIT:chore/taquito-v25-upgrade
Aug 11, 2026
Merged

chore: upgrade Taquito to v25 and drop Beacon overrides#457
KevinMehrabi merged 6 commits into
StableTechnologies:mainfrom
AK-APRIORIT:chore/taquito-v25-upgrade

Conversation

@AK-APRIORIT

Copy link
Copy Markdown
Contributor

No description provided.

@KevinMehrabi
KevinMehrabi self-requested a review July 22, 2026 17:38

@KevinMehrabi KevinMehrabi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold this upgrade until the runtime and frontend testing requirements are addressed.

Taquito 25 requires Node.js 22 or newer, while PR #455 currently pins Node 20.19.5. Please:

  • Pin Node 22 or 24 consistently in CI, local development, and the production build environment.
  • Update the Node version configured in PR #455.
  • Add the actual React production build to CI; the current TypeScript job builds the utility and post-deployment packages but not the UI.
  • Review the direct bignumber.js@9 dependency because Taquito now uses v10 and TezFin exposes BigNumber in TypeScript signatures.
  • Complete Previewnet wallet smoke tests covering Temple and Kukai connection, operation estimation, batching, repayment, and withdrawal.

The dependency upgrade can be approved after those compatibility and wallet-flow checks pass.

@AK-APRIORIT
AK-APRIORIT force-pushed the chore/taquito-v25-upgrade branch from 300ec49 to 1fbaf08 Compare July 30, 2026 14:56
@AK-APRIORIT

Copy link
Copy Markdown
Contributor Author
  • Node 22 has been secured via .nvmrc, engines, and setup-node@v4.
  • React production build has been added to CI.
  • bignumber.js has been updated to ^10.0.2, with imports adapted.
  • TypeScript has been updated to 4.9.5 to support BigNumber v10 types.
  • README has been updated with instructions.

Linter errors will be fixed in another PR - #456

@KevinMehrabi

Copy link
Copy Markdown
Contributor

I confirm that the Node 22 support, BigNumber v10 update, TypeScript update, and production UI build were added.

The PR is still not ready for approval:

  1. The TypeScript/UI check remains failing.
  2. The branch now conflicts with main following the merge of PR chore: updated deployment scripts #455.
  3. The lint work in PRs chore: update irm and comptroller in ui #456/fix: fixed linter warnings #460 has not been incorporated here.
  4. The branch should preserve the exact Node 22.16.0 configuration now used by main.
  5. The requested Temple and Kukai Previewnet wallet tests have not been provided.

Please resolve #456/#460, rebase this branch onto the updated main, resolve the overlapping UI changes, rerun the complete CI suite, and provide the wallet test results before requesting another review.

@AK-APRIORIT
AK-APRIORIT force-pushed the chore/taquito-v25-upgrade branch 3 times, most recently from fb1bb60 to d62ebfa Compare August 5, 2026 13:16
@AK-APRIORIT

Copy link
Copy Markdown
Contributor Author
  1. The TypeScript/UI check is still failing because the linter errors were fixed in another pull request - chore: update irm and comptroller in ui #456 . Once that PR is merged, the TypeScript/UI check will work correctly
  2. The conflict with the main branch has been resolved
  3. There's no point in adding linter fixes to this PR. If PR chore: update irm and comptroller in ui #456 is merged before the current one, it will be enough to rebase it onto the updated main branch.
  4. The branch now preserves the exact configuration of Node 22.16.0, which is currently used in the main branch
  5. Temple wallet tests were conducted in PR chore: update irm and comptroller in ui #456. Kukai Wallet does not support previewnet

@AK-APRIORIT
AK-APRIORIT force-pushed the chore/taquito-v25-upgrade branch 2 times, most recently from 2e9e4ef to 143b834 Compare August 6, 2026 10:07
@AK-APRIORIT

Copy link
Copy Markdown
Contributor Author

rebased chore/taquito-v25-upgrade to current main branch and repeated the Temple Previewnet repayment and withdrawal canary testing:

repay.withdraw.Taquito.25.0.mov

@AK-APRIORIT
AK-APRIORIT force-pushed the chore/taquito-v25-upgrade branch from cf6830d to 5dbdc7f Compare August 6, 2026 10:59
@KevinMehrabi

Copy link
Copy Markdown
Contributor

Thanks. Most of the original requirements are now addressed and CI is green.

Before PR #457 can be approved, please restrict the getPrice failure fallback to Guard recovery mode. The current implementation catches oracle failures and substitutes zero on every network. Recovery mode may continue with zero/unavailable prices because borrowing and supplying are disabled, but normal operation should fail closed rather than silently use a zero price.

Please add regression tests demonstrating that:

  1. Recovery mode remains available for repayment and withdrawal when getPrice fails.
  2. Normal mode does not suppress an oracle failure.

Finally, the previous Temple canary occurred before the current head commit:

5dbdc7f

Because that commit also modified TezosLendingPlatform.ts, including the repayment and withdrawal operation builders, please repeat the Temple Previewnet repayment and withdrawal canary using the exact current head and provide both full operation hashes.

@AK-APRIORIT

Copy link
Copy Markdown
Contributor Author

Withdraw - opAevFJcneC7CV8ynKJibxckVd8azq1YSL5MdQLuqf3aFGau5S2
Repay - op8sWVLv7ZJcLDU5ZQZBd52XbHihbVQ2nR36id56e92FiXJshTh

TezFin.repay.withdraw.V2.mov

@KevinMehrabi

Copy link
Copy Markdown
Contributor

Thanks. I confirmed that the recovery-only oracle fallback and both requested regression tests were added. I also verified that both submitted Previewnet operations were applied successfully.

PR #457 still needs to be updated from the current main branch following the merge of PR #459. Please incorporate current main and rerun the complete CI suite.

If that synchronization does not modify src/util or the existing transaction UI under src/ui, the submitted repayment and withdrawal canaries do not need to be repeated.

@AK-APRIORIT
AK-APRIORIT force-pushed the chore/taquito-v25-upgrade branch from 66519b4 to 5b5e84f Compare August 11, 2026 08:09
@KevinMehrabi
KevinMehrabi merged commit 83b4e48 into StableTechnologies:main Aug 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants