chore: upgrade Taquito to v25 and drop Beacon overrides - #457
Conversation
KevinMehrabi
left a comment
There was a problem hiding this comment.
Please hold this upgrade until the runtime and frontend testing requirements are addressed.
Taquito 25 requires Node.js 22 or newer, while PR #455 currently pins Node 20.19.5. Please:
- Pin Node 22 or 24 consistently in CI, local development, and the production build environment.
- Update the Node version configured in PR #455.
- Add the actual React production build to CI; the current TypeScript job builds the utility and post-deployment packages but not the UI.
- Review the direct
bignumber.js@9dependency because Taquito now uses v10 and TezFin exposesBigNumberin TypeScript signatures. - Complete Previewnet wallet smoke tests covering Temple and Kukai connection, operation estimation, batching, repayment, and withdrawal.
The dependency upgrade can be approved after those compatibility and wallet-flow checks pass.
300ec49 to
1fbaf08
Compare
Linter errors will be fixed in another PR - #456 |
|
I confirm that the Node 22 support, BigNumber v10 update, TypeScript update, and production UI build were added. The PR is still not ready for approval:
Please resolve #456/#460, rebase this branch onto the updated main, resolve the overlapping UI changes, rerun the complete CI suite, and provide the wallet test results before requesting another review. |
fb1bb60 to
d62ebfa
Compare
|
2e9e4ef to
143b834
Compare
|
rebased chore/taquito-v25-upgrade to current main branch and repeated the Temple Previewnet repayment and withdrawal canary testing: repay.withdraw.Taquito.25.0.mov |
cf6830d to
5dbdc7f
Compare
|
Thanks. Most of the original requirements are now addressed and CI is green. Before PR #457 can be approved, please restrict the getPrice failure fallback to Guard recovery mode. The current implementation catches oracle failures and substitutes zero on every network. Recovery mode may continue with zero/unavailable prices because borrowing and supplying are disabled, but normal operation should fail closed rather than silently use a zero price. Please add regression tests demonstrating that:
Finally, the previous Temple canary occurred before the current head commit: Because that commit also modified TezosLendingPlatform.ts, including the repayment and withdrawal operation builders, please repeat the Temple Previewnet repayment and withdrawal canary using the exact current head and provide both full operation hashes. |
|
Withdraw - opAevFJcneC7CV8ynKJibxckVd8azq1YSL5MdQLuqf3aFGau5S2 TezFin.repay.withdraw.V2.mov |
|
Thanks. I confirmed that the recovery-only oracle fallback and both requested regression tests were added. I also verified that both submitted Previewnet operations were applied successfully. PR #457 still needs to be updated from the current main branch following the merge of PR #459. Please incorporate current main and rerun the complete CI suite. If that synchronization does not modify src/util or the existing transaction UI under src/ui, the submitted repayment and withdrawal canaries do not need to be repeated. |
66519b4 to
5b5e84f
Compare
No description provided.