fedramp(image): apt-get upgrade in Dockerfile (EOL base; rebase tracked separately) - #3
Open
geekshiv-spotdraft wants to merge 1 commit into
Open
fedramp(image): apt-get upgrade in Dockerfile (EOL base; rebase tracked separately)#3geekshiv-spotdraft wants to merge 1 commit into
geekshiv-spotdraft wants to merge 1 commit into
Conversation
Adds 'apt-get upgrade -y' alongside the existing apt RUN line so any remaining Debian security backports available for the node:12 base (Debian 9 stretch) get applied at build time. NOTE: node:12 + Debian 9 stretch are both EOL upstream. apt-get upgrade will only apply patches that are still mirrored on the archive / security repos. The proper fix is a base-image rebase (node 20 + Debian 12, plus chrome-headless on Debian 12) - that is a major behaviour change tracked separately under the chrome-print rebase epic and is intentionally out of scope for this PR.
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
Adds `apt-get upgrade -y` to the existing apt RUN line so any remaining Debian security backports available for the `node:12` base (Debian 9 stretch) get applied at build time.
Important caveat
`node:12` and Debian 9 stretch are both EOL upstream. `apt-get upgrade` only applies what's still mirrored on the archive / security repos. The proper fix is a base-image rebase to:
That is a behaviour-changing migration tracked separately under the chrome-print rebase epic and is intentionally out of scope for this 0-breaking-risk PR.
Findings only fully cleared by the rebase
The CISA-KEV `libfreetype6` CVE and the large libwebp / imagemagick stack from the scan all require the base-image rebase. This PR is a partial hardening only.
Test plan
Made with Cursor
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Apply Debian security backports during the Docker build by running
apt-get updatefollowed byapt-get upgradebefore installinglibnss3andlibfontconfigfor the chrome-headless build. Preserve the existing Chrome dependency copy from theyukinying/chrome-headlessbase for thenode:12image.Latest Contributors(2)