Proofread all documentation and finish the shared-agents symlink migration#83
Open
alexander-yevsyukov wants to merge 11 commits into
Open
Proofread all documentation and finish the shared-agents symlink migration#83alexander-yevsyukov wants to merge 11 commits into
alexander-yevsyukov wants to merge 11 commits into
Conversation
Link `.agents/skills`, `.agents/scripts`, and `.agents/guidelines` into the `.agents/shared` submodule, and link `.claude/commands` and `.claude/agents`. Move `project.md` to `docs/`, leaving `.agents/project.md` as a symlink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Refresh `AGENTS.md`, Junie guidelines, Copilot instructions, and the Hugo-tuned Claude settings distributed by `config`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The root `init-submodules` script bootstraps config-managed submodules in fresh worktrees. Add the org-wide `secret-scan` workflow and refresh `check-links`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
`.idea/misc.xml` is now project-local and no longer tracked. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fix missing articles, a restrictive "which", a comma splice, a sentence fragment, a "you/your" typo, and an unhyphenated compound modifier in `README.md`, `CONTRIBUTING.md`, `EMBEDDING.md`, `SPINE_RELEASE.md`, and `_diagrams/README.md`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fix a comma splice and two restrictive "which" clauses in `.agents/memory/reference/cache-warm-window.md`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fix missing articles and a restrictive "which" in the Javadoc and proto doc comments of the `docs/_code/samples` sources. Copyright headers of the touched files are refreshed by the `update-copyright` hook. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fix catalog errors across `docs/content`, the preview index, and the
architecture-diagram script: restrictive "which" clauses, missing and
wrong articles, subject-verb agreement, "allows to" complementation,
compound-modifier hyphens, comma splices and missing commas after
introductory clauses, double spaces, and real-word typos ("defied",
"verifiers", "out", "withing", "constrains", "fine-graded").
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two workstreams on this branch:
1. Shared-agents submodule migration (completes
./config/pull)fcf00ddhad updated theconfigsubmodule and registered.agents/sharedin.gitmodules, but the migration aborted before creating the symlinks — a stale gitignored Lychee cache under.agents/skills/check-links/.cache/tripped the data-loss guard inadopt-shared-agents. After clearing that cache and re-running./config/pull, this branch:.agents/{skills,scripts,guidelines},.claude/{commands,agents}— into the.agents/sharedsubmodule;project.mdtodocs/with.agents/project.mdas a back-symlink;AGENTS.md, Junie, Copilot, Hugo-tuned Claude settings);init-submodulesand the org-widesecret-scanworkflow; merges the shared.gitignoreand untracks.idea/misc.xml.2. Full-repo proofread (
/proofread all)~150 English grammar/punctuation/spelling fixes across 24 project-owned files — Markdown docs, KDoc/Javadoc, and Protobuf/JS doc comments. Dominant classes: restrictive "which"→"that", missing articles, subject–verb agreement, "allows to"→"allows -ing", compound-modifier hyphens, comma splices, and real-word typos ("defied"→"defined", "verifiers"→"verifies", "constrains"→"constraints", "fine-graded"→"fine-grained"). No code tokens, string literals, or machine-read directives were touched.
Why
agentssubmodule instead of stale copied files.config-pull prose sweep.Reviewer notes
AGENTS.md, skip config-distributed files in review (AGENTS.md,CLAUDE.md,.junie/guidelines.md,.github/copilot-instructions.md,.idea/**,init-submodules, distributed workflows) — they are upstream-owned. The reviewable content is thedocs/**prose, code-sample comments, and the symlink structure.java_outer_classname, a misspelled Gradle keyword in a snippet, prefix/suffix and package-name mismatches against their own examples, a missing proto semicolon, a stalechmodpath, a misquoted book subtitle) are out of scope and tracked in a separate follow-up.🤖 Generated with Claude Code