Skip to content

Add a Comparatives entry to the English style catalog#40

Open
alexander-yevsyukov wants to merge 2 commits into
masterfrom
add-comparatives-catalog-entry
Open

Add a Comparatives entry to the English style catalog#40
alexander-yevsyukov wants to merge 2 commits into
masterfrom
add-comparatives-catalog-entry

Conversation

@alexander-yevsyukov

Copy link
Copy Markdown
Contributor

Problem

The catalog has no entry for comparatives that drop their function words, so
the fixer walks past constructions like:

  • "greater or equal zero" → greater than or equal to zero
  • "less or equal zero" → less than or equal to zero
  • "equal or greater than 10" → greater than or equal to 10

There was no existing home for this. Prepositions opens with "Fix only the
pairs listed here" and is scoped to verb–preposition pairings; "than" is a
conjunction, not a preposition. Confusables covers writing "then" for
"than", which is a different error.

This is a calque of the Russian «больше или равно X», where the comparative
governs the case of the noun and no separate function word surfaces — the same
interference pattern the catalog already documents for articles and for
"allows to do".

Where it surfaced

SpineEventEngine/time, in the Javadoc of LocalDates.checkDate:

<li>the day is less or equal zero or greater than can be in the month.

It survived a full proofread sweep of that repository, which is what exposed
the gap.

What this adds

A ### Comparatives section between Verb complementation and Commas
with the grammar entries, ahead of the mechanics ones. It follows the house
layout: rationale paragraph, Before/After table, Leave alone: guards.

The guards keep the fixer off:

  • already-complete "greater than or equal to" / "less than or equal to";
  • >=, <=, a >= b inside code spans — code tokens, not prose;
  • "at least" / "at most" / "no less than" idioms, complete without "or equal";
  • transitive "equals" — "the result equals zero" takes no "to".

Notes

  • Documentation only; no skill or script changes. No skill hard-codes the
    catalog's topic list — proofread groups its report by whatever headings the
    file contains — so this needs no lockstep update.
  • The second commit reflows two runts the review-docs prose-flow check found
    in the first. Table cells use the house alignment; no changed line exceeds
    the 100-character limit.

alexander-yevsyukov and others added 2 commits July 25, 2026 01:52
The catalog had no entry for comparatives that drop their function
words, so "greater or equal zero" and "less or equal zero" passed the
fixer untouched. Prepositions is an explicitly closed list scoped to
verb-preposition pairings, and "than" is a conjunction, so the
construction had no home there either.

Found in SpineEventEngine/time, where the Javadoc of
`LocalDates.checkDate` carried "the day is less or equal zero" through a
full proofread sweep.

The new section sits with the grammar entries, ahead of the mechanics
ones. Guards keep the fixer off already-complete forms, `>=` and `<=` in
code spans, the "at least" / "no less than" idioms, and transitive
"equals". Writing "then" for "than" stays with Confusables, which
already covers it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The `review-docs` prose-flow check flagged two paragraphs whose last line
held a single short word ("complete." and "*Confusables*."). Both now fit
on one line, well inside the 100-character limit.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 25, 2026 00:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “Comparatives” entry to the English style catalog to cover comparative constructions that omit required function words (e.g., “less or equal zero”), filling a gap that existing sections (Prepositions/Confusables) don’t address.

Changes:

  • Introduces a ### Comparatives section with rationale, before/after examples, and “Leave alone” guards.
  • Places the new section between “Verb complementation” and “Commas” to keep grammar topics grouped ahead of mechanics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants