Add a Comparatives entry to the English style catalog#40
Open
alexander-yevsyukov wants to merge 2 commits into
Open
Add a Comparatives entry to the English style catalog#40alexander-yevsyukov wants to merge 2 commits into
alexander-yevsyukov wants to merge 2 commits into
Conversation
The catalog had no entry for comparatives that drop their function words, so "greater or equal zero" and "less or equal zero" passed the fixer untouched. Prepositions is an explicitly closed list scoped to verb-preposition pairings, and "than" is a conjunction, so the construction had no home there either. Found in SpineEventEngine/time, where the Javadoc of `LocalDates.checkDate` carried "the day is less or equal zero" through a full proofread sweep. The new section sits with the grammar entries, ahead of the mechanics ones. Guards keep the fixer off already-complete forms, `>=` and `<=` in code spans, the "at least" / "no less than" idioms, and transitive "equals". Writing "then" for "than" stays with Confusables, which already covers it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The `review-docs` prose-flow check flagged two paragraphs whose last line
held a single short word ("complete." and "*Confusables*."). Both now fit
on one line, well inside the 100-character limit.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Comparatives” entry to the English style catalog to cover comparative constructions that omit required function words (e.g., “less or equal zero”), filling a gap that existing sections (Prepositions/Confusables) don’t address.
Changes:
- Introduces a
### Comparativessection with rationale, before/after examples, and “Leave alone” guards. - Places the new section between “Verb complementation” and “Commas” to keep grammar topics grouped ahead of mechanics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The catalog has no entry for comparatives that drop their function words, so
the fixer walks past constructions like:
There was no existing home for this. Prepositions opens with "Fix only the
pairs listed here" and is scoped to verb–preposition pairings; "than" is a
conjunction, not a preposition. Confusables covers writing "then" for
"than", which is a different error.
This is a calque of the Russian «больше или равно X», where the comparative
governs the case of the noun and no separate function word surfaces — the same
interference pattern the catalog already documents for articles and for
"allows to do".
Where it surfaced
SpineEventEngine/time, in the Javadoc ofLocalDates.checkDate:It survived a full
proofreadsweep of that repository, which is what exposedthe gap.
What this adds
A
### Comparativessection between Verb complementation and Commas —with the grammar entries, ahead of the mechanics ones. It follows the house
layout: rationale paragraph, Before/After table,
Leave alone:guards.The guards keep the fixer off:
>=,<=,a >= binside code spans — code tokens, not prose;Notes
catalog's topic list —
proofreadgroups its report by whatever headings thefile contains — so this needs no lockstep update.
review-docsprose-flow check foundin the first. Table cells use the house alignment; no changed line exceeds
the 100-character limit.