You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR provides a focused Telegram group-management foundation: permissions-aware promotions, moderation actions, invite links, and join-request approval or decline, with request-option handling separated from Bot API JSON payloads.
It does not claim the complete #65 delivery. Broader spam protection, admin action logging, performance validation, and full coverage evidence remain follow-up work unless maintainers explicitly accept this partial slice.
Review assist for #65 at current head ab27b2f1ed60385050d2dcfa1963a3a05077c943 (OPEN / MERGEABLE / REVIEW_REQUIRED; no prior comments, reviews, or visible checks):
The new handlers put :plug inside request_body (for example Map.take(params, [:chat_id, :user_id, :until_date, :plug])) and then call Client.request/3 with only %{json: request_body}. The tests pass a tuple such as {Req.Test, __MODULE__} as params.plug, so Req/Jason is asked to JSON-encode that test tuple instead of receiving it as the top-level client option. This makes the claimed tests non-runnable and also leaks a test-only field into Telegram payloads. Please remove :plug from JSON bodies and, if per-test injection is needed, pass it as request_opts[:plug] (the existing UnitAPICase Telegram client config may already be sufficient).
PromoteChatMember exposes only is_anonymous and can_manage_chat; it cannot express the core admin permissions needed for Telegram Group Management ($1,800) #65 (delete messages, restrict members, invite users, pin messages, manage topics/video chats, etc.). The generic validate_param/2 also accepts maps for scalar IDs, so direct handler calls can send invalid user_id values despite the declared schema.
This 20-file slice implements ten CRUD-style Bot API calls, but Telegram Group Management ($1,800) #65 still requires content moderation, spam protection, admin action logging, documentation/examples, >90% coverage evidence, performance validation, and a clear member-add path (invite link or join-request approval, since bots cannot directly add arbitrary members). Please either narrow the PR body to a partial group-management slice or add the missing acceptance surfaces and focused validation proof.
Run-Id: run-20260712T020631Z-misa3-revenue-cycle-lux924-review
Trace-Id: 96e48c8f-2cc8-40e3-a069-e8dd46209d8f
Requester: service automation ID million-dollar-revenue-cycle
Implementer: MISA 3 bot ID 1516725819517567077
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #65.
This PR provides a focused Telegram group-management foundation: permissions-aware promotions, moderation actions, invite links, and join-request approval or decline, with request-option handling separated from Bot API JSON payloads.
It does not claim the complete #65 delivery. Broader spam protection, admin action logging, performance validation, and full coverage evidence remain follow-up work unless maintainers explicitly accept this partial slice.