Resolve CLI resource profiles by printer vendor - #803
Open
adenta wants to merge 1 commit into
Open
Conversation
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a focused follow-up to #689 for the profile-resolution part of headless CLI slicing. It does not replace the existing crash fixes in #560, #561, #562, or #761.
The CLI currently resolves embedded system presets and printer model metadata through hard-coded
profiles/BBLpaths. This change introduces an internalResourceProfileResolverthat:SM_U1);OrcaFilamentLibraryinheritance;cli_config.json.Bambu Lab remains the same supported path, but it is no longer the only hard-coded profile root. There are no public CLI syntax changes.
Relationship to existing PRs
normalize_fdm()null dereference.Those fixes are complementary and intentionally excluded from this diff.
Validation
Snapmaker_Orcaandlibslic3r_tests: passed.libslic3r_tests '[ResourceProfileResolver]': 34 assertions in 4 test cases, all passed.SM_U1, shared filaments, ambiguousGeneric PLA, and BBL regression behavior.BL-P001under vendorBBL, exit 0 in 2.07 s.The combined validation branch and test models are not part of this PR.