renderer/gles: disable fence export after runtime failure - #2148
Open
krissedout wants to merge 2 commits into
Open
renderer/gles: disable fence export after runtime failure#2148krissedout wants to merge 2 commits into
krissedout wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some context:
GlesRenderer enables ExportFence when the required GL extension is advertised. Some drivers advertise support but still fail when Smithay attempts to create the EGL fence, occasionally without setting an EGL error.
export_sync_point currently returns None after that failure but retains the capability, causing the same failing EGL call and warning to repeat every frame.
Once fence creation fails for a renderer context, this change removes ExportFence from that renderer’s capabilities. Smithay then follows its existing glFinish fallback path, preserving synchronization and correctness without repeated EGL calls.
Checklist