Skip to content

renderer/gles: disable fence export after runtime failure - #2148

Open
krissedout wants to merge 2 commits into
Smithay:masterfrom
krissedout:fix/disable-broken-egl-fence-export
Open

renderer/gles: disable fence export after runtime failure#2148
krissedout wants to merge 2 commits into
Smithay:masterfrom
krissedout:fix/disable-broken-egl-fence-export

Conversation

@krissedout

Copy link
Copy Markdown

Description

  • disable ExportFence after EGLFence::create fails at runtime
  • use the existing synchronized glFinish fallback for the failed frame and subsequent frames
  • avoid retrying a broken eglCreateSync call on every rendered frame

Some context:
GlesRenderer enables ExportFence when the required GL extension is advertised. Some drivers advertise support but still fail when Smithay attempts to create the EGL fence, occasionally without setting an EGL error.

export_sync_point currently returns None after that failure but retains the capability, causing the same failing EGL call and warning to repeat every frame.

Once fence creation fails for a renderer context, this change removes ExportFence from that renderer’s capabilities. Smithay then follows its existing glFinish fallback path, preserving synchronization and correctness without repeated EGL calls.

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant