[CLOV-1901] Remove React 19.x upper cap in peer dependencies - #4972
Open
Ezreal Yang (Supremeyh) wants to merge 2 commits into
Open
[CLOV-1901] Remove React 19.x upper cap in peer dependencies#4972Ezreal Yang (Supremeyh) wants to merge 2 commits into
Ezreal Yang (Supremeyh) wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates Backpack Web’s React peer dependency constraints to allow React 19 without an explicit upper patch cap.
Changes:
- Replace bounded React/ReactDOM peer dependency ranges with semver-compatible ranges covering React 18 and 19.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Visit https://backpack.github.io/storybook-prs/4972 to see this build running in a browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Widen the
reactandreact-dompeer dependency range inpackages/backpack-web/package.jsonfrom the pinned18.3.1 - 19.2.5to^18.3.1 || ^19.0.0.Why
The tight range was deliberately set during the React 19 migration to avoid install conflicts across repos while rolling out support. Now that migration is complete, the pin is no longer needed — and it breaks consumers on any React patch beyond
19.2.5(e.g.19.2.6).Mirrors the same change already made to bpk-logos in bpk-logos#434.
Remember to include the following changes:
[Clover-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md