Skip to content

[CLOV-1901] Remove React 19.x upper cap in peer dependencies - #4972

Open
Ezreal Yang (Supremeyh) wants to merge 2 commits into
mainfrom
cl/clov-1901_react_version
Open

[CLOV-1901] Remove React 19.x upper cap in peer dependencies#4972
Ezreal Yang (Supremeyh) wants to merge 2 commits into
mainfrom
cl/clov-1901_react_version

Conversation

@Supremeyh

@Supremeyh Ezreal Yang (Supremeyh) commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

What

Widen the react and react-dom peer dependency range in packages/backpack-web/package.json from the pinned 18.3.1 - 19.2.5 to ^18.3.1 || ^19.0.0.

Why

The tight range was deliberately set during the React 19 migration to avoid install conflicts across repos while rolling out support. Now that migration is complete, the pin is no longer needed — and it breaks consumers on any React patch beyond 19.2.5 (e.g. 19.2.6).

Mirrors the same change already made to bpk-logos in bpk-logos#434.


Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copilot AI review requested due to automatic review settings July 27, 2026 09:20
@Supremeyh Ezreal Yang (Supremeyh) added the patch Patch production bug label Jul 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Updates Backpack Web’s React peer dependency constraints to allow React 19 without an explicit upper patch cap.

Changes:

  • Replace bounded React/ReactDOM peer dependency ranges with semver-compatible ranges covering React 18 and 19.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/backpack-web/package.json
Comment thread packages/backpack-web/package.json
@Supremeyh Ezreal Yang (Supremeyh) changed the title [CLOV-1901] Widen React peer dep range to 19 [CLOV-1901] Remove React 19.x upper cap in peer dependencies Jul 27, 2026
@skyscanner-backpack-bot

Copy link
Copy Markdown
Contributor

Visit https://backpack.github.io/storybook-prs/4972 to see this build running in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Patch production bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants