Fix Oxygenbar and Vanilla Mana Bar Overlap - #2637
Open
ADON15c wants to merge 1 commit into
Open
Conversation
| // Workaround, can be removed when https://github.com/FabricMC/fabric-api/issues/5517 is fixed. See VanillaStylemanaBar.java for proper fix | ||
| @ModifyReturnValue(method = "getAirBubbleYLine", at = @At("RETURN")) | ||
| private int skyblocker$adjustAirBubbleHeight(int original) { | ||
| return VanillaStyleManaBar.isEnabled() ? original - 10 : original; |
Collaborator
There was a problem hiding this comment.
I’m a bit confused, shouldn’t this be +10 when enabled?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses workaround to fix vanilla mana bar overlap without breaking bars height. Includes proper fix and comments referencing FabricMC/fabric-api#5517 so it can be implemented properly when the bug is fixed