Skip to content

Quick nav config screen - #2607

Open
viciscat wants to merge 15 commits into
SkyblockerMod:mainfrom
viciscat:quick-nav-config-screen
Open

Quick nav config screen#2607
viciscat wants to merge 15 commits into
SkyblockerMod:mainfrom
viciscat:quick-nav-config-screen

Conversation

@viciscat

Copy link
Copy Markdown
Collaborator

also adds an edit box that has its own suggestions thing (probably what took the most time to do lol)

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 30, 2026
@AzureAaron AzureAaron added this to the 6.10.0 milestone Jul 30, 2026
@viciscat
viciscat force-pushed the quick-nav-config-screen branch from c77449e to d6d9261 Compare July 31, 2026 10:29

@kevinthegreat1 kevinthegreat1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you open the config ui from yacl/moul, edit something, and close it, the corresponding config entries in yacl/moul does not show new values.

Comment thread src/main/resources/assets/skyblocker/lang/en_us.json Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file is very skull, but I'll let it pass.

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Aug 2, 2026
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Aug 2, 2026

@kevinthegreat1 kevinthegreat1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after AzureAaron/Dandelion#14 we can just make the button disabled.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me please Pull requests that are ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants