Custom cleanup - #2605
Open
kevinthegreat1 wants to merge 4 commits into
Open
Conversation
kevinthegreat1
marked this pull request as ready for review
July 31, 2026 02:16
LifeIsAParadox
added
reviews needed
Collaborator
Author
|
Works fine, including resizing, I'll just merge soon if no one reviews. |
viciscat
requested changes
Jul 31, 2026
viciscat
left a comment
viciscat
left a comment
Collaborator
There was a problem hiding this comment.
not sure why you removed the resizing code? (the doLayout method) it wasn't perfect that's for sure but 🤷
Also can you fix the bug where it crashes if the width of the screen is smaller than like 55 or something like that
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
# Conflicts: # src/main/java/de/hysky/skyblocker/utils/render/gui/SearchableGridWidget.java
Collaborator
Author
|
Does not center correctly on weird widths because the color selection widget doesn't go below a certain width. (I know, the color selection widget is not even visible.) I'm not fixing that in this pr. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
negative 10x developer
For the width stuff, the idea is that widgets have a set width initialized at init, and parent/layout widgets work with that, instead of the child widget having to deal with whoever being able to set its width to whatever they want.