Skip to content

Add rare crops chat filter - #2542

Open
LJNeon wants to merge 4 commits into
SkyblockerMod:mainfrom
LJNeon:garden-chat-filters
Open

Add rare crops chat filter#2542
LJNeon wants to merge 4 commits into
SkyblockerMod:mainfrom
LJNeon:garden-chat-filters

Conversation

@LJNeon

@LJNeon LJNeon commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Referenced the autopet filter code to implement this. Used the independent wiki as a source for a full list of rare crops.

Primary motivation is adding icons to toasts without needing legitimately 23 different chat rules to do it as a player. Also added Ray of Helios to the list of items with a special drop animation, I think it more than deserves that given it's extreme rarity and high value.

Testing

image

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 14, 2026
@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Jul 14, 2026
@AzureAaron AzureAaron added this to the 6.8.0 milestone Jul 14, 2026
@LJNeon
LJNeon force-pushed the garden-chat-filters branch 2 times, most recently from ec59902 to e2e7685 Compare July 17, 2026 04:07

@viciscat viciscat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also aaron will probably stab you for not using String.format for the patterns that use skyblock icons

Comment thread src/main/java/de/hysky/skyblocker/skyblock/chat/filters/RareCropFilter.java Outdated
@LJNeon

LJNeon commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

The existing regexes like this that I saw all used concatenation with regular +s for skyblock icons so I did the same, is this also something that needs changed or are regexes a special case?

@AzureAaron AzureAaron modified the milestones: 6.8.0, 6.9.0 Jul 26, 2026
@LJNeon
LJNeon force-pushed the garden-chat-filters branch 2 times, most recently from 2beb43c to 1126295 Compare July 27, 2026 08:38
@LJNeon
LJNeon force-pushed the garden-chat-filters branch from 1126295 to 7faffd0 Compare August 12, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature This issue or PR is a new feature reviews needed This PR needs reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants