Fix the build - #45
Open
JonnyRa wants to merge 2 commits into
Open
Conversation
…s step was erroring with ``` godot-haskell> c2hs: C header contains errors: godot-haskell> godot-haskell> .stack-work/dist/x86_64-linux-tinfo6/ghc-8.6.4/build/Godot/Gdnative/Internal/Gdnative.i:1: (column 1) [ERROR] >>> Lexical error ! godot-haskell> The character '#' does not fit here. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in https://discord.com/channels/603723949586644997/901706587566120970/threads/1515815836345176295
I can't make an issue in the repo as I don't have permissions but if you pull the repository from fresh it doesn't build with the error message (coming from c2hs)
setting extra-deps in stack.yaml for newer versions of c2hs and it's underlying parser (language c) to newer versions fixes the build error.
The only other changes in the branch are automatic ones to the stack.yaml.lock and by hpack to remake cabal files. In general cabal files don't need to be committed these days, although of course you may have reasons so I included the updated ones in a separate commit.
Cheers
Jonny