Skip to content

[WIP] MS-1451 Module selection rework #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luhmirin-s wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[WIP] MS-1451 Module selection rework #1790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4dab4bc
MS-1451 Add blank feature module
luhmirin-s Aug 4, 2026
84cf6b9
MS-1451 Move the password dialog to shared ui-base
luhmirin-s Aug 13, 2026
f9ec0ad
MS-1451 Reimplement module selector as a dialog fragment
luhmirin-s Aug 17, 2026
58d271b
MS-1451 Replace usage of module selection with the new dialog
luhmirin-s Aug 17, 2026
ec2e75d
MS-1451 Remove old implementation
luhmirin-s Aug 17, 2026
ed60fb4
MS-1451 Convert modal dialog to a regular fragment for better UI
luhmirin-s Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions feature/dashboard/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ dependencies {
implementation(project(":feature:consent"))
implementation(project(":feature:login"))
implementation(project(":feature:troubleshooting"))
implementation(project(":feature:module-selector"))
implementation(project(":feature:storage-alert"))
// Data Generator is a test-only feature, only included in debug builds
debugImplementation(project(":testing:data-generator"))
Expand Down
2 changes: 1 addition & 1 deletion ...main/java/com/simprints/feature/dashboard/logout/syncdecline/LogoutSyncDeclineFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import com.simprints.core.livedata.LiveDataEventWithContentObserver
import com.simprints.feature.dashboard.R
import com.simprints.feature.dashboard.databinding.FragmentLogoutSyncDeclineBinding
import com.simprints.feature.dashboard.logout.LogoutSyncViewModel
import com.simprints.feature.dashboard.settings.password.SettingsPasswordDialogFragment
import com.simprints.infra.uibase.password.SettingsPasswordDialogFragment
import com.simprints.infra.uibase.viewbinding.viewBinding
import dagger.hilt.android.AndroidEntryPoint
import com.simprints.infra.resources.R as IDR
Expand Down
2 changes: 1 addition & 1 deletion feature/dashboard/src/main/java/com/simprints/feature/dashboard/settings/SettingsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ import com.simprints.core.livedata.LiveDataEventWithContentObserver
import com.simprints.feature.dashboard.DashboardActivity
import com.simprints.feature.dashboard.R
import com.simprints.feature.dashboard.databinding.FragmentSettingsBinding
import com.simprints.feature.dashboard.settings.password.SettingsPasswordDialogFragment
import com.simprints.infra.uibase.navigation.navigateSafely
import com.simprints.infra.uibase.password.SettingsPasswordDialogFragment
import com.simprints.infra.uibase.view.applySystemBarInsets
import com.simprints.infra.uibase.viewbinding.viewBinding
import dagger.hilt.android.AndroidEntryPoint
Expand Down
2 changes: 1 addition & 1 deletion ...e/dashboard/src/main/java/com/simprints/feature/dashboard/settings/about/AboutFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import com.simprints.core.livedata.LiveDataEventObserver
import com.simprints.core.livedata.LiveDataEventWithContentObserver
import com.simprints.feature.dashboard.R
import com.simprints.feature.dashboard.databinding.FragmentSettingsAboutBinding
import com.simprints.feature.dashboard.settings.password.SettingsPasswordDialogFragment
import com.simprints.infra.uibase.navigation.navigateSafely
import com.simprints.infra.uibase.password.SettingsPasswordDialogFragment
import com.simprints.infra.uibase.system.Clipboard
import com.simprints.infra.uibase.view.applySystemBarInsets
import com.simprints.infra.uibase.viewbinding.viewBinding
Expand Down
312 changes: 0 additions & 312 deletions .../simprints/feature/dashboard/settings/syncinfo/moduleselection/ModuleSelectionFragment.kt
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions ...rints/feature/dashboard/settings/syncinfo/moduleselection/ModuleSelectionQueryListener.kt
View file
Open in desktop

This file was deleted.

Loading