Skip to content

More non-convergence diagnostics - #414

Draft
luke-kiernan wants to merge 4 commits into
mainfrom
lk/pf-diagnostics
Draft

More non-convergence diagnostics#414
luke-kiernan wants to merge 4 commits into
mainfrom
lk/pf-diagnostics

Conversation

@luke-kiernan

Copy link
Copy Markdown
Collaborator

Some WIP stuff to better diagnose non-convergence

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Performance Results

Precompile Time

Main This Branch Delta
2.214 s 2.069 s -6.6%

Solve Time

Polar AC

Test Main This Branch Delta
NewtonRaphsonACPowerFlow First Solve 12.807 s 12.509 s -2.3%
NewtonRaphsonACPowerFlow Second Solve 115.0 ms 57.3 ms -50.2%
NewtonRaphsonACPowerFlow(iwamoto) First Solve 10.391 s 9.9 s -4.7%
NewtonRaphsonACPowerFlow(iwamoto) Second Solve 58.6 ms 92.0 ms +57.0%
TrustRegionACPowerFlow(iwamoto) First Solve 11.852 s 11.365 s -4.1%
TrustRegionACPowerFlow(iwamoto) Second Solve 70.3 ms 59.4 ms -15.5%
RobustHomotopyPowerFlow First Solve 20.133 s 19.5 s -3.1%
RobustHomotopyPowerFlow Second Solve 6.413 s 6.215 s -3.1%
FastDecoupledFixed First Solve 12.43 s 12.249 s -1.5%
FastDecoupledFixed Second Solve 62.7 ms 61.3 ms -2.2%
FastDecoupledXB(tol=1e-2) First Solve 11.523 s 10.841 s -5.9%
FastDecoupledXB(tol=1e-2) Second Solve 310.4 ms 306.6 ms -1.2%
FastDecoupledBX(tol=1e-2) First Solve 11.057 s 11.303 s +2.2%
FastDecoupledBX(tol=1e-2) Second Solve 318.1 ms 320.0 ms +0.6%
NewtonRaphsonACPowerFlow First Solve 746.8 ms 903.4 ms +21.0%
NewtonRaphsonACPowerFlow Second Solve 722.3 ms 901.3 ms +24.8%
TrustRegionACPowerFlow First Solve 11.112 s 10.869 s -2.2%
TrustRegionACPowerFlow Second Solve 1.001 s 1.849 s +84.7%
FastDecoupledFixed First Solve 645.7 ms 557.3 ms -13.7%
FastDecoupledFixed Second Solve 816.7 ms 616.0 ms -24.6%
FastDecoupledXB First Solve 11.206 s 11.927 s +6.4%
FastDecoupledXB Second Solve 1.272 s 1.581 s +24.3%
FastDecoupledBX First Solve 12.582 s 10.83 s -13.9%
FastDecoupledBX Second Solve 886.2 ms 981.2 ms +10.7%

Rectangular CI

Test Main This Branch Delta
ACRectangularPowerFlow{NR} First Solve 11.429 s 10.9 s -4.6%
ACRectangularPowerFlow{NR} Second Solve 31.9 ms 54.3 ms +70.5%
ACRectangularPowerFlow{NR}(iwamoto) First Solve 9.648 s 9.385 s -2.7%
ACRectangularPowerFlow{NR}(iwamoto) Second Solve 51.2 ms 32.0 ms -37.6%
ACRectangularPowerFlow{TR} First Solve 12.267 s 10.961 s -10.6%
ACRectangularPowerFlow{TR} Second Solve 34.4 ms 37.2 ms +8.2%
ACRectangularPowerFlow{TR}(iwamoto_fallback) First Solve 9.722 s 9.593 s -1.3%
ACRectangularPowerFlow{TR}(iwamoto_fallback) Second Solve 33.6 ms 51.3 ms +52.6%

Mixed CPB

Test Main This Branch Delta
ACMixedPowerFlow{NR} First Solve 11.243 s 11.501 s +2.3%
ACMixedPowerFlow{NR} Second Solve 33.8 ms 33.4 ms -1.2%
ACMixedPowerFlow{NR}(iwamoto) First Solve 9.908 s 9.313 s -6.0%
ACMixedPowerFlow{NR}(iwamoto) Second Solve 40.4 ms 33.5 ms -17.1%
ACMixedPowerFlow{TR} First Solve 11.267 s 10.779 s -4.3%
ACMixedPowerFlow{TR} Second Solve 63.2 ms 35.2 ms -44.4%
ACMixedPowerFlow{TR}(iwamoto_fallback) First Solve 9.666 s 9.937 s +2.8%
ACMixedPowerFlow{TR}(iwamoto_fallback) Second Solve 34.8 ms 35.4 ms +1.8%
ACMixedPowerFlow{LM} First Solve 12.041 s 12.632 s +4.9%
ACMixedPowerFlow{LM} Second Solve 1.154 s 1.109 s -3.9%

DC

Test Main This Branch Delta
DCPowerFlow First Solve 1.207 s 1.127 s -6.7%
DCPowerFlow Second Solve 46.4 ms 11.3 ms -75.7%
PTDFDCPowerFlow First Solve 768.3 ms 781.5 ms +1.7%
PTDFDCPowerFlow Second Solve 57.6 ms 57.3 ms -0.5%
vPTDFDCPowerFlow First Solve 7.07 s 5.742 s -18.8%
vPTDFDCPowerFlow Second Solve 4.574 s 4.762 s +4.1%
DCPowerFlow First Solve 325.8 ms 156.1 ms -52.1%
DCPowerFlow Second Solve 170.7 ms 162.2 ms -5.0%

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.29630% with 226 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/residual_condition_diagnostics.jl 16.29% 226 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants