Skip to content

Fix issue #242: S-bend disconnect in path_to_waveguide. - #245

Open
FaresBadrCA wants to merge 1 commit into
SiEPIC:mainfrom
FaresBadrCA:main
Open

Fix issue #242: S-bend disconnect in path_to_waveguide.#245
FaresBadrCA wants to merge 1 commit into
SiEPIC:mainfrom
FaresBadrCA:main

Conversation

@FaresBadrCA

@FaresBadrCA FaresBadrCA commented Jan 26, 2026

Copy link
Copy Markdown

Issue Description:

In path_to_waveguide, a normal 90-bend followed by an S-bend will create a disconnect in the waveguide. This applies only to S-bends around the third point in the path.


Cause:

There is an off-by-one error in the check for clearance of S-bends. The third point in the path (P2) is treated as an 'end point', so the check for S-bend viability assumes the segment P1->P2 is all available for use, which is incorrect, since part of that segment is already 'used up' by the previous bend (around P1).

image

Solution:
Fix indices in S-bend clearance check so that the third point in a path is an inner point, not an end point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant