Fix issue #242: S-bend disconnect in path_to_waveguide. - #245
Open
FaresBadrCA wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description:
In
path_to_waveguide, a normal 90-bend followed by an S-bend will create a disconnect in the waveguide. This applies only to S-bends around the third point in the path.Cause:
There is an off-by-one error in the check for clearance of S-bends. The third point in the path (P2) is treated as an 'end point', so the check for S-bend viability assumes the segment P1->P2 is all available for use, which is incorrect, since part of that segment is already 'used up' by the previous bend (around P1).
Solution:
Fix indices in S-bend clearance check so that the third point in a path is an inner point, not an end point.