Skip to content

Add auto to POS button variant type - #4625

Open
henryStelle wants to merge 1 commit into
2026-10-rcfrom
henry/add-missing-auto-button-variant-option
Open

Add auto to POS button variant type#4625
henryStelle wants to merge 1 commit into
2026-10-rcfrom
henry/add-missing-auto-button-variant-option

Conversation

@henryStelle

@henryStelle henryStelle commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Background

Fixes https://github.com/shop/issues-retail/issues/33323.

The POS s-button documentation identifies auto as the default variant, but the public button variant type only allowed primary and secondary.

Solution

Add auto to the POS button variant type and generated documentation, and document it alongside the other supported variants.

Validation

  • yarn build
  • yarn type-check
  • yarn lint
  • Targeted TypeScript compile check for variant: 'auto'

The full yarn test -- packages/ui-extensions/ command is currently blocked by the missing react-test-renderer dependency in unrelated Checkout suites.

image

🎩

  • Confirm a POS extension can type-check <s-button variant="auto">.

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

Forward-port of #4627, #4629, #4628, #4626

@fatbattk fatbattk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm but does auto actually work?

determines the button variant based on its context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants