Add auto to POS button variant type - #4625
Open
henryStelle wants to merge 1 commit into
Open
Conversation
This was referenced Aug 14, 2026
fatbattk
approved these changes
Aug 14, 2026
fatbattk
left a comment
Contributor
There was a problem hiding this comment.
code lgtm but does auto actually work?
determines the button variant based on its context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fixes https://github.com/shop/issues-retail/issues/33323.
The POS
s-buttondocumentation identifiesautoas the default variant, but the public button variant type only allowedprimaryandsecondary.Solution
Add
autoto the POS button variant type and generated documentation, and document it alongside the other supported variants.Validation
yarn buildyarn type-checkyarn lintvariant: 'auto'The full
yarn test -- packages/ui-extensions/command is currently blocked by the missingreact-test-rendererdependency in unrelated Checkout suites.🎩
<s-button variant="auto">.Checklist
Forward-port of #4627, #4629, #4628, #4626