Add theme dev reconciliation strategy flag#7634
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 25, 2026
bc8df22 to
c635c86
Compare
b73773b to
8f6ca1c
Compare
17976d9 to
a727f50
Compare
8f6ca1c to
fee06e6
Compare
cf17902 to
f1bd642
Compare
fee06e6 to
ad55535
Compare
f1bd642 to
e4069c5
Compare
ad55535 to
8d70823
Compare
4 tasks
e4069c5 to
c5d2d3f
Compare
c5d2d3f to
2b45cf7
Compare
1202d52 to
c22f504
Compare
2b45cf7 to
3fcd3c1
Compare
c22f504 to
155a4b3
Compare
3fcd3c1 to
e4ccca0
Compare
155a4b3 to
bc9aaca
Compare
e4ccca0 to
469f7c2
Compare
bc9aaca to
b1b95a3
Compare
b016c6e to
f3e0e23
Compare
37116bd to
6c7775b
Compare
f3e0e23 to
6a3739f
Compare
6c7775b to
d840f99
Compare
65d4a29 to
c8f3233
Compare
21264f3 to
0141b85
Compare
c8f3233 to
21d20b2
Compare
karreiro
approved these changes
Jul 13, 2026
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this PR, @gonzaloriestra!
I looked into it, and the alternatives for implementing the single-flag approach are indeed hacky. It also reveals that having union types (boolean | string) in CLI flags might not be the ideal pattern. So, from my side, +1 for proceeding with this approach.
Thanks again for this PR!
21d20b2 to
722bab8
Compare
0a8a2d3 to
42c3570
Compare
722bab8 to
ea966f3
Compare
42c3570 to
8d0d5a2
Compare
ea966f3 to
eb2c7e6
Compare
8d0d5a2 to
4f7a225
Compare
isaacroldan
approved these changes
Jul 13, 2026
eb2c7e6 to
84b78ef
Compare
4f7a225 to
6de9f11
Compare
84b78ef to
94683f9
Compare
6de9f11 to
d2e7a6a
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.5.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.4.0";
\ No newline at end of file
|
94683f9 to
fb770af
Compare
d2e7a6a to
20c6377
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/22873
The interactivity audit found that theme dev with --theme-editor-sync could still prompt when JSON files needed reconciliation.
WHAT is this pull request doing?
How to test your changes?
Make a change in a theme file (like templates/404.json) locally and remotely and run:
Checklist