fix(Ayaneo 3): match the joystick rings LED sys_name by glob - #666
Open
matmartinez wants to merge 1 commit into
Open
fix(Ayaneo 3): match the joystick rings LED sys_name by glob#666matmartinez wants to merge 1 commit into
matmartinez wants to merge 1 commit into
Conversation
The hid-ayaneo driver merged in OpenGamingCollective/linux-unstable#3 registers the joystick rings LED with a per-device name ("<hid dev name>:rgb:joystick_rings", e.g. "0003:1C4F:0002.0003:rgb:joystick_rings") rather than the fixed "ayaneo:rgb:joystick_rings", following review feedback there. sys_name is matched with glob_match(), so a wildcard prefix covers both the old fixed name and the new per-device one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
hid-ayaneodriver just merged in OpenGamingCollective/linux-unstable#3 registers the AYANEO 3 joystick-rings LED with a per-device name (<hid device name>:rgb:joystick_rings, e.g.0003:1C4F:0002.0003:rgb:joystick_rings) instead of the fixedayaneo:rgb:joystick_ringsthis config expects — the prefix was changed todev_name()during kernel review, since a fixed LED name can collide.sys_nameis matched withglob_match(), so a wildcard prefix keeps this entry working with both the old fixed name and the new per-device one (the composite device is DMI-gated to the AYANEO 3, so the glob can't over-match on other hardware).Verified on an AYANEO 3 on Bazzite 44 with the merged driver: the LED registers as
0003:1C4F:0002.0003:rgb:joystick_ringsand the HID device (and thus the LED path) is recreated on every controller power cycle, which is why matching by exact name is brittle.Related: ShadowBlip/OpenGamepadUI#528 (magic-modules integration coordination).