feat(tee-cli)!: drop the ceremony's -g/--genesis-hash override - #82
Merged
Conversation
The ceremony already fails closed on both sources of that value: the template's sha256 is checked against summit.genesis_template_hash, and every node's real block 0 is asserted equal to the manifest's eth.genesis_hash before anything is built. Past those gates the committed template carries the identical hash (assemble fills it), so passing -g to the summit genesis binary overwrote equal with equal — and the flag's only real user was the dev-only --genesis-hash override, which let an operator diverge the delivered genesis.toml from the committed identity with just a warning. genesis.toml is now a pure function of the manifest-committed template bytes plus the gathered validator set. Deploy-only change (the summit binary's -g is Option); the network-dir diagram's ceremony caption is updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ceremony already fails closed on both sources of that value: the template's sha256 is checked against summit.genesis_template_hash, and every node's real block 0 is asserted equal to the manifest's eth.genesis_hash before anything is built. Past those gates the committed template carries the identical hash (assemble fills it), so passing -g to the summit genesis binary overwrote equal with equal — and the flag's only real user was the dev-only --genesis-hash override, which let an operator diverge the delivered genesis.toml from the committed identity with just a warning.
genesis.toml is now a pure function of the manifest-committed template bytes plus the gathered validator set. Deploy-only change (the summit binary's -g is Option); the network-dir diagram's ceremony caption is updated to match.