[gui] Add arrival Set active/inactive by distance/azimuth/residual#204
Open
comoglu wants to merge 1 commit into
Open
[gui] Add arrival Set active/inactive by distance/azimuth/residual#204comoglu wants to merge 1 commit into
comoglu wants to merge 1 commit into
Conversation
Adds two submenus, reachable both from the arrival table and from every plot tab (Distance, Azimuth, Travel time, Move-out, Polar): "Set active by..." -> Distance range..., Residual threshold..., Azimuth range... -- prompts for a range/threshold and resets state: arrivals matching the criterion are activated, everything else is deactivated. Same mechanism as dragging a rectangle on the Distance plot tab (residualsSelected()), just precise/typed and available for azimuth and residual too, and not tied to which tab happens to be open. "Set inactive by..." -> same three criteria, but surgical: only deactivates arrivals matching the criterion, leaves everything else untouched. Useful for e.g. excluding a known-bad distance band or knocking out residual outliers without disturbing other manual choices. Distance respects SCScheme.unit.distanceInKM like the DISTANCE column. Residual threshold is a single |time residual| cutoff in seconds (not a range), matching how outlier-killing is normally framed. The plot tabs reach the same six OriginLocatorView actions via six new signals on OriginLocatorPlot (setActiveByDistanceRequested() etc.), emitted by PlotWidget's context menu and connected in the constructor -- same pattern already used for focalMechanismCommitted()/ autoInversionRequested(). The six actions themselves moved from a plain private: section to private slots: to make them connectable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
residualsSelected()), just typed/precise and available regardless of which tab happens to be open.SCScheme.unit.distanceInKM, same as the DISTANCE column.Background
Started from a simple "deactivate picks beyond a distance" request. @gempa-jabe suggested reusing the existing Select + Activate/Deactivate submenu pattern; I tried that and found it cost an extra manual step for the common case (select, then separately trigger Deactivate → All), so this does select+apply in one action instead — matching how dragging a rectangle on the plot tabs already works today, just typed and criterion-agnostic instead of tied to whichever axis the current tab happens to plot.
Notes for review
Test plan
--debugand confirmed noQObject::connectwarnings for the new signal/slot wiring (OriginLocatorPlot→OriginLocatorView)main: only one commit since base (gempa-jabe's own felt-report change) touches this file, in a disjoint region