Skip to content

Applied bug fixes and updated tests. - #334

Open
davidknight-seequent wants to merge 1 commit into
SeequentEvo:mainfrom
davidknight-seequent:dataframe-bugfix
Open

Applied bug fixes and updated tests.#334
davidknight-seequent wants to merge 1 commit into
SeequentEvo:mainfrom
davidknight-seequent:dataframe-bugfix

Conversation

@davidknight-seequent

Copy link
Copy Markdown
Contributor

Summary

Fix several typed-object data-access paths that passed the wrong object into schema construction and used an outdated pointset table method.

  • DataTable.update_dataframe() now passes the owning Evo object to _data_to_schema() instead of the internal model context. This ensures the data client receives an object implementing the expected context accessors.
  • SchemaBuilder now accepts the broader IContext interface, matching the contexts used by typed-object schema construction.
  • PointSet.coordinates() now uses to_dataframe() on its locations table, restoring coordinate retrieval through the current table API.

Test Coverage

Strengthened typed-object test mocks so patched get_data_client() calls verify that their input exposes the required context API:

  • get_connector()
  • get_environment()
  • get_cache()

This makes tests fail when a model context is passed where an Evo object is required.

Added a pointset regression test confirming that coordinates() returns only the x, y, and z columns. Updated affected tests to use the stricter mock helper.

Validation

uv run --directory packages/evo-objects pytest tests/typed -q

Checklist

  • I have read the contributing guide and the code of conduct

@davidknight-seequent
davidknight-seequent requested a review from a team as a code owner August 19, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant