Applied bug fixes and updated tests. - #334
Open
davidknight-seequent wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix several typed-object data-access paths that passed the wrong object into schema construction and used an outdated pointset table method.
DataTable.update_dataframe()now passes the owning Evo object to_data_to_schema()instead of the internal model context. This ensures the data client receives an object implementing the expected context accessors.SchemaBuildernow accepts the broaderIContextinterface, matching the contexts used by typed-object schema construction.PointSet.coordinates()now usesto_dataframe()on its locations table, restoring coordinate retrieval through the current table API.Test Coverage
Strengthened typed-object test mocks so patched
get_data_client()calls verify that their input exposes the required context API:get_connector()get_environment()get_cache()This makes tests fail when a model context is passed where an Evo object is required.
Added a pointset regression test confirming that
coordinates()returns only thex,y, andzcolumns. Updated affected tests to use the stricter mock helper.Validation
Checklist