Handle some race conditions in downloading data - #333
Merged
grantroch merged 2 commits intoAug 20, 2026
Conversation
GriffinBaxterSeequent
approved these changes
Aug 19, 2026
GriffinBaxterSeequent
left a comment
Member
There was a problem hiding this comment.
Nice one! Do note that you'll want to bump the version for evo-sdk-common
AdamFreemanSeequent
self-requested a review
August 19, 2026 01:36
AdamFreemanSeequent
approved these changes
Aug 19, 2026
GriffinBaxterSeequent
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix a couple race conditions that can happen when downloading data.
download_fileit can be the case that two different processes download the same file at the same time. They will both download different temporary files, but if one finishes downloading and renames before the other one, the second process will throw aPermissionError. If the file exists, thePermissionErroris ignored and the destination path points to a valid file.Checklist