fix(analytics): distinguish registered and installed providers - #268
Merged
Conversation
yaacovcorcos
marked this pull request as ready for review
September 9, 2026 06:19
yaacovcorcos
enabled auto-merge (squash)
September 9, 2026 06:19
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Provider analytics now reports explicit installed state from canonical provider snapshots. Bundled-but-missing providers report false; installation/removal changes update the state. Multiple configured instances are aggregated per provider driver, and pending probes defer the aggregate observation.
Why
The previous discovery event represented registered providers, including missing runtimes, and omitted the authoritative installed flag. Revision 4 separates installation state from readiness without exposing instance identifiers. Existing consent, activation, notifications, and provider management remain unchanged.
Verification
Desktop analytics package: 34 tests passed. Focused mapper/contract tests after alignment with main: 17 passed. Analytics and server typechecks, server bundle build, formatting, generated gateway parity, and the cross-repository built worker/gateway/ledger pipeline test passed. Full monorepo qualification is left to CI; no UI changes.
Documentation Impact
Documentation impact: Updated — docs/internals/product-analytics.md.
Dependency
Deploy the companion website/gateway revision-4 validator before releasing this desktop producer: ScientFactory/ScientFactory-website#39. Both PRs can merge independently; desktop merging does not publish an application release.
Implementation: Codex assistant. Final delivery review: GPT-6 in Codex desktop.