Further component bugfixes and improvements - #481
Merged
Conversation
kulcsaradam
force-pushed
the
additional_component_fixes
branch
2 times, most recently
from
August 24, 2026 08:21
dca3823 to
eaf4664
Compare
Remove file type from WasiRefCounted and fix bugs. Signed-off-by: Ádám László Kulcsár <adam.kulcsar@szteszoftver.hu>
kulcsaradam
force-pushed
the
additional_component_fixes
branch
from
August 25, 2026 07:35
eaf4664 to
e18f5ff
Compare
zherczeg
requested changes
Aug 26, 2026
| options->memory()->buffer()[offset] = resultError; | ||
| } | ||
|
|
||
| uint32_t offset = argv[4].asI32(); |
Collaborator
There was a problem hiding this comment.
Is this ok to remove handling of argv[5] and argv[6]?
Contributor
Author
There was a problem hiding this comment.
stat-at doesnt actaully have those arguments, they were left in by mistake. It only has a self pointer, pathflags, a path and a path length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove file type from WasiRefCounted and fix bugs.