[pull] main from danielmiessler:main - #263
Merged
Merged
Conversation
- Declare Fish completion arguments for dynamic and fixed values - Enable filtered file suggestions for supported path options - Add Spotify, transcription, metadata, and wire-debug completion options - Include Grok among providers supporting web search completion - Localize pattern, Spotify, and metadata help descriptions consistently - Document expanded completion coverage and wire-level debug behavior - Describe YouTube visual flags directly in generated help
- Specify input and output tokens in flag help text - Synchronize metadata descriptions across shell completion definitions - Localize clarified metadata guidance across supported languages - Record description clarification in incoming changelog entry
fix: declare completion arguments and synchronize CLI help
PR #2092 added Grok (xAI) web search support and updated the go-flags struct tag in internal/cli/flags.go, but `fabric --help` renders flag descriptions from the i18n message catalog (internal/cli/help.go maps "search" -> "enable_web_search_tool"), not from the struct tag. The catalog value still listed only Anthropic, OpenAI, and Gemini, so the Grok support stayed undiscoverable in --help even though it works. Append "Grok" to the enable_web_search_tool value in all 11 locales, using each locale's own list separator, and update the generated README help block to match. No functional change. The zsh and fish completion strings were already corrected in #2179, so this carries forward only the remaining parts of #2140. Co-Authored-By: Ken Hartman <khartman@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fix: include Grok in localized --search help text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )