fix(codex): recover legacy thread names - #396
Open
huzhongyyuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #395.
Backfills legacy Codex thread names from
session_index.jsonlinto blankthreads.namevalues during startup, allowing native Codex CLI and VS Code surfaces to retain renamed session titles after provider/relay changes.Safety properties:
threads.name, preserving archive and unrelated state;sqlite_home;BEGIN IMMEDIATE, source snapshot/digest checks, a fresh SQLite backup, and a per-DB transactional ledger;Validation:
cargo fmt --checkcargo test codex_history_migration::tests:: --lib(52 passed)cargo test settings::tests:: --lib(19 passed)git diff --checkRepository-wide
cargo clippyremains blocked on unchangedsrc/cli/tui/ui/home_chart.rs:806(reversed_empty_ranges). Full integration-test compilation also has unchanged test-harness errors intests/settings_current_provider.rsandtests/settings_visible_apps.rs; these are not introduced by this patch.Related upstream Codex reports: openai/codex#16405 and openai/codex#16280.